From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>, cocci@systeme.lip6.fr
Cc: Yi Wang <wang.yi59@zte.com.cn>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>,
linux-kernel@vger.kernel.org, Wen Yang <wen.yang99@zte.com.cn>
Subject: Re: [Cocci] [v2] coccinelle: semantic code search for missing of_node_put
Date: Fri, 28 Jun 2019 16:16:08 +0200 [thread overview]
Message-ID: <36196c4e-a09f-3d0d-5a08-68fa53ee740a@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1906281304470.2538@hadrien>
>> +x =
>> +(of_…
>> +|of_…
>> +)@p1(...);
>
> Did you actually test this? I doubt that a position metavariable can be
> put on a ) of a disjunction.
Would you ever like to support this possibility?
>> +|return
>> +(x
>> +|of_fwnode_handle(x)
>> +);
>
> The original code is much more readable.
We have got different views around such specification variants.
> The internal representation will be the same.
I imagine that the Coccinelle software might evolve into additional directions.
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2019-06-28 14:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 2:58 [Cocci] [PATCH v2] coccinelle: semantic code search for missing of_node_put Wen Yang
2019-06-28 9:38 ` Markus Elfring
2019-06-28 11:07 ` Julia Lawall
2019-06-28 14:16 ` [Cocci] [v2] " Markus Elfring
2019-06-28 14:16 ` Markus Elfring [this message]
2019-07-04 3:03 ` [Cocci] [PATCH v2] coccinelle: semantic code search for missingof_node_put wen.yang99
2019-07-04 6:28 ` [Cocci] [v2] coccinelle: semantic code search for missing of_node_put Markus Elfring
2019-07-05 5:29 ` [Cocci] [PATCH v2] coccinelle: semantic code search for missingof_node_put Julia Lawall
2019-07-05 5:57 ` [Cocci] [PATCH v2] coccinelle: semantic code search formissingof_node_put wen.yang99
2019-07-05 6:17 ` Julia Lawall
2019-07-05 6:45 ` [Cocci] [v2] coccinelle: semantic code search for missing of_node_put Markus Elfring
2019-06-29 7:40 ` Markus Elfring
2019-06-29 7:49 ` Julia Lawall
2019-06-29 8:35 ` Markus Elfring
2019-06-29 19:30 ` [Cocci] [v2] Coccinelle: Testing SmPL constraints Markus Elfring
2019-07-04 2:41 ` [Cocci] 答复: Re: [PATCH v2] coccinelle: semantic code search for missingof_node_put wen.yang99
2019-07-04 5:40 ` [Cocci] [v2] coccinelle: semantic code search for missing of_node_put Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36196c4e-a09f-3d0d-5a08-68fa53ee740a@web.de \
--to=markus.elfring@web.de \
--cc=cocci@systeme.lip6.fr \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).