Coccinelle archive on lore.kernel.org
 help / color / Atom feed
* Re: [Cocci] [PATCH 06/26] parsing_cocci: arity: Add cases for ParenType/FunctionType
@ 2020-03-16 19:20 Markus Elfring
  2020-03-17  5:28 ` Jaskaran Singh
  0 siblings, 1 reply; 6+ messages in thread
From: Markus Elfring @ 2020-03-16 19:20 UTC (permalink / raw)
  To: Jaskaran Singh, cocci; +Cc: linux-kernel-mentees

> ParenType and FunctionType are added to the SmPL ASTs.
> Add cases for these types in ….ml.

A change description template was used several times.
I wonder if there is really a need to modify only a single OCaml source file
in these update steps.
How do you think about to combine such changes in a bigger update step?

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Cocci] [PATCH 06/26] parsing_cocci: arity: Add cases for ParenType/FunctionType
  2020-03-16 19:20 [Cocci] [PATCH 06/26] parsing_cocci: arity: Add cases for ParenType/FunctionType Markus Elfring
@ 2020-03-17  5:28 ` Jaskaran Singh
  2020-03-17  8:40   ` [Cocci] [06/26] " Markus Elfring
  0 siblings, 1 reply; 6+ messages in thread
From: Jaskaran Singh @ 2020-03-17  5:28 UTC (permalink / raw)
  To: Markus Elfring; +Cc: linux-kernel-mentees, cocci

On Mon, 2020-03-16 at 20:20 +0100, Markus Elfring wrote:
> > ParenType and FunctionType are added to the SmPL ASTs.
> > Add cases for these types in ….ml.
> 
> A change description template was used several times.
> I wonder if there is really a need to modify only a single OCaml
> source file
> in these update steps.
> How do you think about to combine such changes in a bigger update
> step?
> 

These are separated this way so that it's easier for Julia to review.
She will probably just squash all 26 of these together and apply them
later.

Cheers,
Jaskaran.

> Regards,
> Markus

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Cocci] [06/26] parsing_cocci: arity: Add cases for ParenType/FunctionType
  2020-03-17  5:28 ` Jaskaran Singh
@ 2020-03-17  8:40   ` " Markus Elfring
  2020-03-17  8:53     ` Julia Lawall
  0 siblings, 1 reply; 6+ messages in thread
From: Markus Elfring @ 2020-03-17  8:40 UTC (permalink / raw)
  To: Jaskaran Singh, cocci; +Cc: linux-kernel-mentees

>> How do you think about to combine such changes in a bigger update step?
>
> These are separated this way so that it's easier for Julia to review.

I suggest to reconsider such an approach.


> She will probably just squash all 26 of these together and apply them later.

I got special views also around patch squashing.
Would you like to reduce the number of update steps
according to the really desired software transformation?

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Cocci] [06/26] parsing_cocci: arity: Add cases for ParenType/FunctionType
  2020-03-17  8:40   ` [Cocci] [06/26] " Markus Elfring
@ 2020-03-17  8:53     ` Julia Lawall
  2020-03-17  8:57       ` Markus Elfring
  0 siblings, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2020-03-17  8:53 UTC (permalink / raw)
  To: Markus Elfring; +Cc: linux-kernel-mentees, cocci



On Tue, 17 Mar 2020, Markus Elfring wrote:

> >> How do you think about to combine such changes in a bigger update step?
> >
> > These are separated this way so that it's easier for Julia to review.
>
> I suggest to reconsider such an approach.
>
>
> > She will probably just squash all 26 of these together and apply them later.
>
> I got special views also around patch squashing.
> Would you like to reduce the number of update steps
> according to the really desired software transformation?

I asked him to cut it up into small chunks.

julia
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Cocci] [06/26] parsing_cocci: arity: Add cases for ParenType/FunctionType
  2020-03-17  8:53     ` Julia Lawall
@ 2020-03-17  8:57       ` Markus Elfring
  0 siblings, 0 replies; 6+ messages in thread
From: Markus Elfring @ 2020-03-17  8:57 UTC (permalink / raw)
  To: Julia Lawall, Jaskaran Singh; +Cc: linux-kernel-mentees, cocci

>> I got special views also around patch squashing.
>> Would you like to reduce the number of update steps
>> according to the really desired software transformation?
>
> I asked him to cut it up into small chunks.

We come along different preferences for the size of these pieces.

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Cocci] [PATCH 06/26] parsing_cocci: arity: Add cases for ParenType/FunctionType
  2020-03-16 10:02 [Cocci] [PATCH 00/26] cocci: Add ParenType/FunctionType to SmPL ASTs Jaskaran Singh
@ 2020-03-16 10:02 ` Jaskaran Singh
  0 siblings, 0 replies; 6+ messages in thread
From: Jaskaran Singh @ 2020-03-16 10:02 UTC (permalink / raw)
  To: cocci; +Cc: linux-kernel-mentees

ParenType and FunctionType are added to the SmPL ASTs. Add
cases for these types in arity.ml.

Signed-off-by: Jaskaran Singh <jaskaransingh7654321@gmail.com>
---
 parsing_cocci/arity.ml | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/parsing_cocci/arity.ml b/parsing_cocci/arity.ml
index f29b86eb..3b408554 100644
--- a/parsing_cocci/arity.ml
+++ b/parsing_cocci/arity.ml
@@ -419,6 +419,23 @@ and top_typeC tgt opt_allowed typ =
       let params = parameter_list tgt params in
       make_typeC typ tgt arity
 	(Ast0.FunctionPointer(ty,lp1,star,rp1,lp2,params,rp2))
+  | Ast0.ParenType(lp,ty,rp) ->
+      let arity =
+        all_same opt_allowed tgt (mcode2line lp)
+        [mcode2arity lp; mcode2arity rp] in
+      let lp = mcode lp in
+      let ty = typeC arity ty in
+      let rp = mcode rp in
+      make_typeC typ tgt arity (Ast0.ParenType(lp,ty,rp))
+  | Ast0.FunctionType(ty,lp,params,rp) ->
+      let arity =
+        all_same opt_allowed tgt (mcode2line lp)
+        [mcode2arity lp; mcode2arity rp] in
+      let ty = typeC arity ty in
+      let lp = mcode lp in
+      let params = parameter_list tgt params in
+      let rp = mcode rp in
+      make_typeC typ tgt arity (Ast0.FunctionType(ty,lp,params,rp))
   | Ast0.Array(ty,lb,size,rb) ->
       let arity =
 	all_same opt_allowed tgt (mcode2line lb)
-- 
2.21.1

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-16 19:20 [Cocci] [PATCH 06/26] parsing_cocci: arity: Add cases for ParenType/FunctionType Markus Elfring
2020-03-17  5:28 ` Jaskaran Singh
2020-03-17  8:40   ` [Cocci] [06/26] " Markus Elfring
2020-03-17  8:53     ` Julia Lawall
2020-03-17  8:57       ` Markus Elfring
  -- strict thread matches above, loose matches on Subject: below --
2020-03-16 10:02 [Cocci] [PATCH 00/26] cocci: Add ParenType/FunctionType to SmPL ASTs Jaskaran Singh
2020-03-16 10:02 ` [Cocci] [PATCH 06/26] parsing_cocci: arity: Add cases for ParenType/FunctionType Jaskaran Singh

Coccinelle archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/cocci/0 cocci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 cocci cocci/ https://lore.kernel.org/cocci \
		cocci@systeme.lip6.fr
	public-inbox-index cocci

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/fr.lip6.systeme.cocci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git