cocci.inria.fr archive mirror
 help / color / mirror / Atom feed
From: Yuehaibing <yuehaibing@huawei.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
	Julia Lawall <julia.lawall@lip6.fr>
Cc: Michal Marek <michal.lkml@markovi.net>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	Matthias Maennich <maennich@google.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] [RFC PATCH] scripts: Fix coccicheck failed
Date: Sun, 6 Oct 2019 12:23:18 +0800	[thread overview]
Message-ID: <490422f5-e33f-3aab-ba2d-747b9fecca91@huawei.com> (raw)
In-Reply-To: <CAK7LNAS2K6i+s2A_xTyRq730M6_=tyjtfwHAnEHF37_nrJa4Eg@mail.gmail.com>



On 2019/10/4 10:32, Masahiro Yamada wrote:
> On Thu, Oct 3, 2019 at 9:23 PM Julia Lawall <julia.lawall@lip6.fr> wrote:
>>
>>
>>
>> On Thu, 3 Oct 2019, Masahiro Yamada wrote:
>>
>>> On Tue, Oct 1, 2019 at 10:01 PM Julia Lawall <julia.lawall@lip6.fr> wrote:
>>>>> diff --git a/scripts/coccinelle/misc/add_namespace.cocci b/scripts/coccinelle/misc/add_namespace.cocci
>>>>> index c832bb6445a8..99e93a6c2e24 100644
>>>>> --- a/scripts/coccinelle/misc/add_namespace.cocci
>>>>> +++ b/scripts/coccinelle/misc/add_namespace.cocci
>>>>> @@ -6,6 +6,8 @@
>>>>>  /// add a missing namespace tag to a module source file.
>>>>>  ///
>>>>>
>>>>> +virtual report
>>>>> +
>>>>>  @has_ns_import@
>>>>>  declarer name MODULE_IMPORT_NS;
>>>>>  identifier virtual.ns;
>>>>>
>>>>>
>>>>>
>>>>> Adding virtual report make the coccicheck go ahead smoothly.
>>>>
>>>> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
>>>>
>>>
>>>
>>> Was this patch posted somewhere?
>>
>> It was probably waiting for moderation in the cocci mailing list.  Do you
>> have it now (or in a few minutes)?
> 
> No. I do not see it yet.
> 
> I want to pick the patch from LKML Patchwork
> https://lore.kernel.org/patchwork/project/lkml/list/
> 
> You gave Acked-by to the one-liner fix "virtual report",
> and I am happy to apply it to my tree.
> 
> YueHaibing, could you submit it as a patch?

Sorry for late, will send it.

> 
> 

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  parent reply	other threads:[~2019-10-06  5:29 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-28  9:42 [Cocci] [RFC PATCH] scripts: Fix coccicheck failed YueHaibing
2019-09-28 12:43 ` Julia Lawall
2019-09-29  2:04   ` Yuehaibing
2019-09-29 16:32     ` Julia Lawall
2019-09-29 18:00       ` Markus Elfring
2019-09-29 18:05         ` Julia Lawall
2019-09-29 18:18           ` [Cocci] [RFC] " Markus Elfring
2019-09-30  2:32       ` [Cocci] [RFC PATCH] " Yuehaibing
2019-10-01 12:57         ` Matthias Maennich
2019-10-01 15:33           ` [Cocci] [RFC] " Markus Elfring
2019-10-01 13:01         ` [Cocci] [RFC PATCH] " Julia Lawall
2019-10-03 11:57           ` Masahiro Yamada
2019-10-03 12:22             ` Julia Lawall
2019-10-04  2:32               ` Masahiro Yamada
2019-10-05 11:17                 ` [Cocci] [RFC] " Markus Elfring
2019-10-05 12:26                   ` Julia Lawall
2019-10-05 17:49                     ` Markus Elfring
2019-10-05 17:49                     ` Markus Elfring
2019-10-06  5:21                     ` Markus Elfring
2019-10-06  5:28                       ` Julia Lawall
2019-10-06  5:34                         ` Markus Elfring
2019-10-06  7:30                           ` Greg Kroah-Hartman
2019-10-06  4:23                 ` Yuehaibing [this message]
2019-10-06  4:44                 ` [Cocci] [PATCH] scripts: add_namespace: " YueHaibing
2019-10-06  6:40                   ` Markus Elfring
2019-10-06  6:44                     ` Julia Lawall
2019-10-06  7:00                       ` [Cocci] " Markus Elfring
2019-10-06 11:09                   ` [Cocci] [PATCH] " Matthias Maennich
2019-10-07 13:15                   ` Jessica Yu
2019-10-03 16:30             ` [Cocci] [RFC] scripts: " Markus Elfring
2019-10-03 16:30             ` Markus Elfring
2019-10-03 19:35               ` Julia Lawall
2019-10-04  8:23                 ` Markus Elfring
2019-09-29  8:20 ` [Cocci] [RFC PATCH] " Markus Elfring
2019-09-29 13:12 ` Markus Elfring
2019-09-29 16:40   ` Julia Lawall
2019-10-02  7:09     ` [Cocci] [PATCH 0/2] Coccinelle: Extend directory hierarchy Markus Elfring
2019-10-02  7:10       ` [Cocci] [PATCH 1/2] Coccinelle: Move the SmPL script “add_namespace.cocci” into a new directory Markus Elfring
2019-10-02  7:12       ` [Cocci] [PATCH 2/2] Coccinelle: Move coccicheck directories into a new subdirectory Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=490422f5-e33f-3aab-ba2d-747b9fecca91@huawei.com \
    --to=yuehaibing@huawei.com \
    --cc=cocci@systeme.lip6.fr \
    --cc=gregkh@linuxfoundation.org \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maennich@google.com \
    --cc=michal.lkml@markovi.net \
    --cc=nicolas.palix@imag.fr \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).