cocci.inria.fr archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Jaskaran Singh <jaskaransingh7654321@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org, cocci@systeme.lip6.fr
Subject: Re: [Cocci] [RFC PATCH 00/25] cocci: Improve C parsing of attributes
Date: Fri, 24 Apr 2020 14:02:43 +0200	[thread overview]
Message-ID: <490913cf-2563-25a5-c977-dadc87da866b@web.de> (raw)

> This patch series aims to improve parsing of attributes in C by
> Coccinelle's C parser.

How do you think about to use the wording “in C source code by”?


> These parsing errors were discovered by running a build of Coccinelle's

Would you like to omit the word “These”?


> Coccinelle currently manages attributes similar to comments,

Will this aspect trigger further software development considerations?


> so to explicity state what the attributes are to the C parser,
> a MACROANNOTATION hint was used in Coccinelle's standard.h file.

I find such information suspicious at first glance.
Additional background information from an update step like
“[RFC PATCH 12/25] parsing_c: cpp_token_c: Introduce MACROANNOTATION hint”
might make the proposed data processing approach more reasonable.
https://lore.kernel.org/cocci/20200424091801.13871-13-jaskaransingh7654321@gmail.com/
https://systeme.lip6.fr/pipermail/cocci/2020-April/007217.html


> Separate patches will be sent for the above.

I am curious how the software evolution will be continued here.

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

             reply	other threads:[~2020-04-24 12:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-24 12:02 Markus Elfring [this message]
2020-04-25 13:15 ` [Cocci] [RFC PATCH 00/25] cocci: Improve C parsing of attributes Jaskaran Singh
2020-04-25 13:42   ` [Cocci] [RFC " Markus Elfring
  -- strict thread matches above, loose matches on Subject: below --
2020-04-24  9:17 [Cocci] [RFC PATCH " Jaskaran Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=490913cf-2563-25a5-c977-dadc87da866b@web.de \
    --to=markus.elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    --cc=jaskaransingh7654321@gmail.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).