From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: "René Scharfe" <l.s.r@web.de>,
"Junio C Hamano" <gitster@pobox.com>,
Coccinelle <cocci@systeme.lip6.fr>,
git@vger.kernel.org
Subject: Re: [Cocci] git-coccinelle: adjustments for array.cocci?
Date: Sat, 16 Nov 2019 07:57:25 +0100 [thread overview]
Message-ID: <4ee4604e-0eb1-d4a6-24bb-52abe0db3f53@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1911152000170.8961@hadrien>
>> https://github.com/git/git/blob/3edfcc65fdfc708c1c8f1d314885eecf9beb9b67/fast-import.c#L640
>>
>> I got the impression that the Coccinelle software is occasionally able
>> to determine from the search specification “sizeof(T)” the corresponding
>> data type for code like “*(t->entries)”.
>
> It can determine the type of t->entries if it has access to the definition
> of the type of t.
Should this type determination always work here because the data structure
“tree_content” for the parameter “t” of the function “grow_tree_content”
is defined in the same source file?
https://github.com/git/git/blob/3edfcc65fdfc708c1c8f1d314885eecf9beb9b67/fast-import.c#L85
> This type may be in a header file. If you want
> Coccinelle to be able to find this information you can use the option
> --all-includes or --recursive-includes. It will be more efficient with
> the option --include-headers-for-types.
Such information can be more helpful in other situations than the mentioned
test case.
>> But it seems that there are circumstances to consider where the desired
>> data type was not automatically determined.
Would you like to take the presented differences from the discussed
before/after comparison better into account?
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2019-11-16 6:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <50c77cdc-2b2d-16c8-b413-5eb6a2bae749@web.de>
[not found] ` <5189f847-1af1-f050-6c72-576a977f6f12@web.de>
[not found] ` <xmqqa790cyp1.fsf@gitster-ct.c.googlers.com>
[not found] ` <fe9b8c08-6fd4-d378-f3ff-8170381b10e0@web.de>
[not found] ` <xmqqr22b9ptk.fsf@gitster-ct.c.googlers.com>
[not found] ` <ba5d609a-16ea-d7e9-66e6-19aab94b2acd@web.de>
[not found] ` <53346d52-e096-c651-f70a-ce6ca4d82ff9@web.de>
[not found] ` <6c4ef61f-5fef-ffc8-82d6-ee42006756b4@web.de>
[not found] ` <aed296a6-bae0-6fcc-515e-ef96fed24ca6@web.de>
2019-11-15 11:11 ` [Cocci] git-coccinelle: adjustments for array.cocci? Markus Elfring
2019-11-15 14:20 ` Markus Elfring
2019-11-15 18:50 ` Markus Elfring
2019-11-16 1:00 ` Julia Lawall
2019-11-16 6:57 ` Markus Elfring [this message]
2019-11-16 8:29 ` Markus Elfring
2019-11-16 17:57 ` Julia Lawall
2019-11-16 18:29 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ee4604e-0eb1-d4a6-24bb-52abe0db3f53@web.de \
--to=markus.elfring@web.de \
--cc=cocci@systeme.lip6.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=julia.lawall@lip6.fr \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).