From: Markus Elfring <Markus.Elfring@web.de>
To: Zhong Shiqi <zhong.shiqi@zte.com.cn>,
cocci@systeme.lip6.fr, kernel-janitors@vger.kernel.org,
linux-doc@vger.kernel.org
Cc: Yi Wang <wang.yi59@zte.com.cn>,
Michal Marek <michal.lkml@markovi.net>,
Jonathan Corbet <corbet@lwn.net>,
Nicolas Palix <nicolas.palix@imag.fr>,
linux-kernel@vger.kernel.org,
Xue Zhihong <xue.zhihong@zte.com.cn>,
Cheng Shengyu <cheng.shengyu@zte.com.cn>
Subject: Re: [Cocci] [PATCH v6] coccicheck: Support search for SmPL scripts within selected directory hierarchy
Date: Mon, 4 Nov 2019 16:40:31 +0100 [thread overview]
Message-ID: <583d2524-6b29-487b-a000-9a764b5ecdec@web.de> (raw)
In-Reply-To: <1572838555-12101-1-git-send-email-zhong.shiqi@zte.com.cn>
> *Allow defining the environment variable “COCCI” as a directory to
> search SmPL scripts.
>
> *Start a corresponding file determination if it contains an acceptable
> path.
>
> *Update coccinelle.rst documents for use coccicheck with a directory
> selection
‣ Do you really insist to use an enumeration without alignment
in your change description?
‣ Can the following third item be nicer?
* Adjust software documentation for using coccicheck with
a selected directory.
> +++ b/Documentation/dev-tools/coccinelle.rst
> @@ -100,8 +100,8 @@ Two other modes provide some common combinations of these modes.
…
> +Using Coccinelle with defalut value
Why did you repeat a typo?
How do you think about to use the section title “Using Coccinelle
with the default configuration”?
…
> +semantic patch. In that case, the variable must be initialized with
> +the name of the semantic patch to apply.
I prefer an other wording.
…, it should be set to the file name of the semantic patch to apply.
…
> +directory. In that case, the variable must be initialized with the name of
…, it should be set to the …
Will the presented case distinction need another adjustment
for the document outline?
…
> Controlling Which Files are Processed by Coccinelle
…
Did you overlook another update candidate (which I tried to point out before)?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/dev-tools/coccinelle.rst?id=a99d8080aaf358d5d23581244e5da23b35e340b9#n189
“…
COCCI variable may additionally be used to only apply a single
semantic patch as shown in the previous section.
…”
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
prev parent reply other threads:[~2019-11-04 15:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 3:35 [Cocci] [PATCH v6] coccicheck: Support search for SmPL scripts within selected directory hierarchy zhongshiqi
2019-11-04 15:40 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=583d2524-6b29-487b-a000-9a764b5ecdec@web.de \
--to=markus.elfring@web.de \
--cc=cheng.shengyu@zte.com.cn \
--cc=cocci@systeme.lip6.fr \
--cc=corbet@lwn.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=wang.yi59@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
--cc=zhong.shiqi@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).