Coccinelle archive on
 help / color / Atom feed
From: Markus Elfring <>
To: Zhong Shiqi <>,,,
Cc: Yi Wang <>,
	Michal Marek <>,
	Jonathan Corbet <>,
	Nicolas Palix <>,,
	Xue Zhihong <>,
	Cheng Shengyu <>
Subject: Re: [Cocci] [PATCH v6] coccicheck: Support search for SmPL scripts within selected directory hierarchy
Date: Mon, 4 Nov 2019 16:40:31 +0100
Message-ID: <> (raw)
In-Reply-To: <>

> *Allow defining the environment variable “COCCI” as a directory to
> search SmPL scripts.
> *Start a corresponding file determination if it contains an acceptable
> path.
> *Update coccinelle.rst documents for use coccicheck with a directory
> selection

‣ Do you really insist to use an enumeration without alignment
  in your change description?

‣ Can the following third item be nicer?

  * Adjust software documentation for using coccicheck with
    a selected directory.

> +++ b/Documentation/dev-tools/coccinelle.rst
> @@ -100,8 +100,8 @@ Two other modes provide some common combinations of these modes.
> +Using Coccinelle with defalut value

Why did you repeat a typo?

How do you think about to use the section title “Using Coccinelle
with the default configuration”?

> +semantic patch. In that case, the variable must be initialized with
> +the name of the semantic patch to apply.

I prefer an other wording.

…, it should be set to the file name of the semantic patch to apply.

> +directory. In that case, the variable must be initialized with the name of

…, it should be set to the …

Will the presented case distinction need another adjustment
for the document outline?

>  Controlling Which Files are Processed by Coccinelle

Did you overlook another update candidate (which I tried to point out before)?
COCCI variable may additionally be used to only apply a single
semantic patch as shown in the previous section.

Cocci mailing list

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-04  3:35 zhongshiqi
2019-11-04 15:40 ` Markus Elfring [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Coccinelle archive on

Archives are clonable:
	git clone --mirror cocci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 cocci cocci/ \
	public-inbox-index cocci

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone