Coccinelle archive on
 help / color / Atom feed
From: Markus Elfring <>
To: Julia Lawall <>, Coccinelle <>
Cc: Kate Stewart <>,
	Yi Wang <>,
	Petr Strnad <>,
	Michal Marek <>,
	Greg Kroah-Hartman <>,
	Nicolas Palix <>,
	LKML <>,
	Thomas Gleixner <>,
	Wen Yang <>,
	Allison Randal <>
Subject: Re: [Cocci] Coccinelle: pci_free_consistent: Checking when constraints
Date: Sun, 8 Sep 2019 14:48:47 +0200
Message-ID: <> (raw)
In-Reply-To: <alpine.DEB.2.21.1909081019020.3340@hadrien>

> The when exists below these lines has an impact.

This parameter should result in a desirable effect.

> I believe that the rule is ok as is.

I wonder about the relevance of the shown double if statement exclusion.

> A single path may have no call to pci_free_consistent,

We come along different views around the provided software functionality
once more.

> but if it has that call under one of the mentioned ifs,
> then the path is still ok,

I find that this information can need further clarification.

> and not something that an error should be reported about.

I do not expect an error message from the SmPL script execution here.

I just try again to clarify if the specification of a single function call
exclusion can (and should) be sufficient also at this place.

Cocci mailing list

  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-08  8:10 Markus Elfring
2019-09-08  8:23 ` Julia Lawall
2019-09-08 12:48   ` Markus Elfring [this message]
     [not found]     ` <alpine.DEB.2.21.1909082149100.2644@hadrien>
2019-09-09 10:40       ` Markus Elfring
2019-09-16  6:24       ` Markus Elfring

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Coccinelle archive on

Archives are clonable:
	git clone --mirror cocci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 cocci cocci/ \
	public-inbox-index cocci

Newsgroup available over NNTP:

AGPL code for this site: git clone public-inbox