Coccinelle Archive on lore.kernel.org
 help / color / Atom feed
* [Cocci] Checking adjustments for pointer resets with SmPL
@ 2020-09-21 15:34 Markus Elfring
  2020-09-21 17:47 ` Markus Elfring
  0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2020-09-21 15:34 UTC (permalink / raw)
  To: Coccinelle

Hello,

I have noticed the update suggestion “USB: quirks: simplify quirk handling”.
https://lore.kernel.org/linux-usb/20200921113039.GA19862@duo.ucw.cz/
https://lore.kernel.org/patchwork/patch/1308991/

Thus I converted a patch hunk into the following script variant for
the semantic patch language (according to the software “Coccinelle 1.0.8-00177-g28737419”).

@adjustment@
identifier allocate, object, release;
@@
-if (object)
-{
-release(object);
-object = NULL;
-}
+release(object);
 object = allocate(..., sizeof(...), ...);


Now I wonder at the moment why a known patch is not generated.
(An error message is not displayed.)

elfring@Sonne:~/Projekte/Linux/next-patched> spatch drivers/usb/core/quirks.c ~/Projekte/Coccinelle/janitor/simplify_pointer_reset2.cocci


Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Cocci] Checking adjustments for pointer resets with SmPL
  2020-09-21 15:34 [Cocci] Checking adjustments for pointer resets with SmPL Markus Elfring
@ 2020-09-21 17:47 ` Markus Elfring
  0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2020-09-21 17:47 UTC (permalink / raw)
  To: Coccinelle; +Cc: Pavel Machek

> I have noticed the update suggestion “USB: quirks: simplify quirk handling”.
> https://lore.kernel.org/linux-usb/20200921113039.GA19862@duo.ucw.cz/
> https://lore.kernel.org/patchwork/patch/1308991/

I would like to point out that an acceptable patch can be generated for
the implementation of the function “quirks_param_set” according to
a known transformation pattern by the following SmPL script variant.

@adjustment@
identifier allocate, object, release;
type t;
@@
-if (object)
-{
-release(object);
-object = NULL;
-}
+release(object);
 object = allocate(..., sizeof(t), ...);


Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21 15:34 [Cocci] Checking adjustments for pointer resets with SmPL Markus Elfring
2020-09-21 17:47 ` Markus Elfring

Coccinelle Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/cocci/0 cocci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 cocci cocci/ https://lore.kernel.org/cocci \
		cocci@systeme.lip6.fr
	public-inbox-index cocci

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/fr.lip6.systeme.cocci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git