From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43B15CA9EB6 for ; Wed, 23 Oct 2019 09:57:46 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7E8E2064A for ; Wed, 23 Oct 2019 09:57:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7E8E2064A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id x9N9vTSV002925; Wed, 23 Oct 2019 11:57:29 +0200 (CEST) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id 7426A77BB; Wed, 23 Oct 2019 11:57:29 +0200 (CEST) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id 9939176F6 for ; Sun, 20 Oct 2019 11:34:59 +0200 (CEST) Received: from inca-roads.misterjones.org (inca-roads.misterjones.org [213.251.177.50]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id x9K9YvkR005961; Sun, 20 Oct 2019 11:34:57 +0200 (CEST) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=big-swifty.misterjones.org) by cheepnis.misterjones.org with esmtpsa (TLSv1.2:AES256-GCM-SHA384:256) (Exim 4.80) (envelope-from ) id 1iM7by-0001qi-Bk; Sun, 20 Oct 2019 11:34:54 +0200 Date: Sun, 20 Oct 2019 10:34:52 +0100 Message-ID: <867e4zzrnn.wl-maz@kernel.org> From: Marc Zyngier To: Julia Lawall In-Reply-To: References: <693a3b68-a0f1-81fe-40ce-2b6ba189450c@web.de> <868spgzcti.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: julia.lawall@lip6.fr, Markus.Elfring@web.de, himanshujha199640@gmail.com, kernel-janitors@vger.kernel.org, cocci@systeme.lip6.fr, alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bgolaszewski@baylibre.com, Gilles.Muller@lip6.fr, gregkh@linuxfoundation.org, torvalds@linuxfoundation.org, linus.walleij@linaro.org, yamada.masahiro@socionext.com, michal.lkml@markovi.net, nicolas.palix@imag.fr, tglx@linutronix.de, yuehaibing@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on cheepnis.misterjones.org); SAEximRunCond expanded to false X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Wed, 23 Oct 2019 11:57:30 +0200 (CEST) X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Sun, 20 Oct 2019 11:34:57 +0200 (CEST) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Mailman-Approved-At: Wed, 23 Oct 2019 11:57:27 +0200 Cc: Alexandre Belloni , Michal Marek , YueHaibing , Arnd Bergmann , Greg Kroah-Hartman , Linus Walleij , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolas Palix , Bartosz Golaszewski , Linus Torvalds , Markus Elfring , Thomas Gleixner , Andy Shevchenko , Coccinelle Subject: Re: [Cocci] coccinelle: api/devm_platform_ioremap_resource: remove useless script X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr On Sun, 20 Oct 2019 06:38:30 +0100, Julia Lawall wrote: > > > If said script was providing a correct semantic patch instead of being > > an incentive for people to churn untested patches that span the whole > > tree, that'd be a different story. But that's not what this is about. > > What is the actual incorrectness with the script? The first thing is that it spits out a "WARNING", which is almost universally interpreted as something that needs addressing. In this case, it really doesn't. The suggested helper is only icing sugar, and the original code is perfectly fine. The second thing is that it results in people posting patches they don't even compile, let alone test. There would be a good chance for these patches to be correct if the script was directly generating them, but that's unfortunately not the case. > An option could be to adjust the rule such that it can be run with an > extra command line option, like -D developer but is not run by default by > make coccicheck. Maybe. I'm not sure this will deter people from running these scripts and sending broken patches anyway. No matter how many safeguards you put, people will still post broken patches just because they can. M. -- Jazz is not dead, it just smells funny. _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci