* [Cocci] [PATCH] Coccinelle: zalloc-simple: Adjust a message construction
@ 2019-11-03 19:30 Markus Elfring
2019-11-03 19:39 ` Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Markus Elfring @ 2019-11-03 19:30 UTC (permalink / raw)
To: cocci, kernel-janitors, Christoph Hellwig, Enrico Weigelt,
Gilles Muller, Greg Kroah-Hartman, Julia Lawall, Kate Stewart,
Luis Chamberlain, Masahiro Yamada, Michal Marek, Nicolas Palix,
Thomas Gleixner
Cc: LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 3 Nov 2019 20:00:30 +0100
* Simplify a message construction in a Python script rule
for the semantic patch language.
* Delete also a duplicate space character then.
Fixes: dfd32cad146e3624970eee9329e99d2c6ef751b3 ("dma-mapping: remove dma_zalloc_coherent()")
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
scripts/coccinelle/api/alloc/zalloc-simple.cocci | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/scripts/coccinelle/api/alloc/zalloc-simple.cocci b/scripts/coccinelle/api/alloc/zalloc-simple.cocci
index 26cda3f48f01..c14eae1f3010 100644
--- a/scripts/coccinelle/api/alloc/zalloc-simple.cocci
+++ b/scripts/coccinelle/api/alloc/zalloc-simple.cocci
@@ -217,8 +217,10 @@ p << r2.p;
x << r2.x;
@@
-msg="WARNING: dma_alloc_coherent use in %s already zeroes out memory, so memset is not needed" % (x)
-coccilib.report.print_report(p[0], msg)
+coccilib.report.print_report(p[0],
+ "WARNING: dma_alloc_coherent use in "
+ + x
+ + " already zeroes out memory. Thus memset is not needed.")
//-----------------------------------------------------------------
@r3 depends on org || report@
--
2.23.0
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Cocci] [PATCH] Coccinelle: zalloc-simple: Adjust a message construction
2019-11-03 19:30 [Cocci] [PATCH] Coccinelle: zalloc-simple: Adjust a message construction Markus Elfring
@ 2019-11-03 19:39 ` Julia Lawall
2019-11-03 21:00 ` [Cocci] " Markus Elfring
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2019-11-03 19:39 UTC (permalink / raw)
To: Markus Elfring
Cc: Kate Stewart, Michal Marek, Greg Kroah-Hartman, Nicolas Palix,
kernel-janitors, LKML, Christoph Hellwig, Thomas Gleixner, cocci
On Sun, 3 Nov 2019, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 3 Nov 2019 20:00:30 +0100
>
> * Simplify a message construction in a Python script rule
> for the semantic patch language.
The benefit is what?
julia
>
> * Delete also a duplicate space character then.
>
> Fixes: dfd32cad146e3624970eee9329e99d2c6ef751b3 ("dma-mapping: remove dma_zalloc_coherent()")
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> scripts/coccinelle/api/alloc/zalloc-simple.cocci | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/coccinelle/api/alloc/zalloc-simple.cocci b/scripts/coccinelle/api/alloc/zalloc-simple.cocci
> index 26cda3f48f01..c14eae1f3010 100644
> --- a/scripts/coccinelle/api/alloc/zalloc-simple.cocci
> +++ b/scripts/coccinelle/api/alloc/zalloc-simple.cocci
> @@ -217,8 +217,10 @@ p << r2.p;
> x << r2.x;
> @@
>
> -msg="WARNING: dma_alloc_coherent use in %s already zeroes out memory, so memset is not needed" % (x)
> -coccilib.report.print_report(p[0], msg)
> +coccilib.report.print_report(p[0],
> + "WARNING: dma_alloc_coherent use in "
> + + x
> + + " already zeroes out memory. Thus memset is not needed.")
>
> //-----------------------------------------------------------------
> @r3 depends on org || report@
> --
> 2.23.0
>
>
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Cocci] Coccinelle: zalloc-simple: Adjust a message construction
2019-11-03 19:39 ` Julia Lawall
@ 2019-11-03 21:00 ` Markus Elfring
0 siblings, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2019-11-03 21:00 UTC (permalink / raw)
To: Julia Lawall, cocci, kernel-janitors
Cc: Kate Stewart, Michal Marek, Greg Kroah-Hartman, Nicolas Palix,
LKML, Thomas Gleixner, Christoph Hellwig
>> * Simplify a message construction in a Python script rule
>> for the semantic patch language.
>
> The benefit is what?
The avoidance to store the shown string in the extra Python variable “msg”.
>> * Delete also a duplicate space character then.
I find the proposed wording a bit nicer, don't you?
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-03 21:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-03 19:30 [Cocci] [PATCH] Coccinelle: zalloc-simple: Adjust a message construction Markus Elfring
2019-11-03 19:39 ` Julia Lawall
2019-11-03 21:00 ` [Cocci] " Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).