[cocci] [PATCH v2 2/3] media: adv748x: Move a variable assignment behind condition checks in adv748x_hdmi_query_dv_timings()

[Markus Elfring <Markus.Elfring@web.de>]

Date: Tue, 18 Apr 2023 09:30:25 +0200

Convert the explicit initialisation of the local variable “bt”
at the beginning to an assignment statement directly before
the source code place where this pointer is used.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---

v2:
The change was rebased on source files from Linux next-20230417.

 drivers/media/i2c/adv748x/adv748x-hdmi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/i2c/adv748x/adv748x-hdmi.c b/drivers/media/i2c/adv748x/adv748x-hdmi.c
index b10263f4c0c0..14ff27aabe89 100644
--- a/drivers/media/i2c/adv748x/adv748x-hdmi.c
+++ b/drivers/media/i2c/adv748x/adv748x-hdmi.c
@@ -274,7 +274,7 @@ static int adv748x_hdmi_query_dv_timings(struct v4l2_subdev *sd,
 {
 	struct adv748x_hdmi *hdmi = adv748x_sd_to_hdmi(sd);
 	struct adv748x_state *state = adv748x_hdmi_to_state(hdmi);
-	struct v4l2_bt_timings *bt = &timings->bt;
+	struct v4l2_bt_timings *bt;
 	int pixelclock;
 	int polarity;

@@ -298,7 +298,7 @@ static int adv748x_hdmi_query_dv_timings(struct v4l2_subdev *sd,
 		return -ENODATA;

 	timings->type = V4L2_DV_BT_656_1120;
-
+	bt = &timings->bt;
 	bt->pixelclock = pixelclock;
 	bt->interlaced = hdmi_read(state, ADV748X_HDMI_F1H1) &
 				ADV748X_HDMI_F1H1_INTERLACED ?
--
2.40.0