* Re: [Cocci] [PATCH 06/26] parsing_cocci: arity: Add cases for ParenType/FunctionType
@ 2020-03-16 19:20 Markus Elfring
2020-03-17 5:28 ` Jaskaran Singh
0 siblings, 1 reply; 5+ messages in thread
From: Markus Elfring @ 2020-03-16 19:20 UTC (permalink / raw)
To: Jaskaran Singh, cocci; +Cc: linux-kernel-mentees
> ParenType and FunctionType are added to the SmPL ASTs.
> Add cases for these types in ….ml.
A change description template was used several times.
I wonder if there is really a need to modify only a single OCaml source file
in these update steps.
How do you think about to combine such changes in a bigger update step?
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Cocci] [PATCH 06/26] parsing_cocci: arity: Add cases for ParenType/FunctionType
2020-03-16 19:20 [Cocci] [PATCH 06/26] parsing_cocci: arity: Add cases for ParenType/FunctionType Markus Elfring
@ 2020-03-17 5:28 ` Jaskaran Singh
2020-03-17 8:40 ` [Cocci] [06/26] " Markus Elfring
0 siblings, 1 reply; 5+ messages in thread
From: Jaskaran Singh @ 2020-03-17 5:28 UTC (permalink / raw)
To: Markus Elfring; +Cc: linux-kernel-mentees, cocci
On Mon, 2020-03-16 at 20:20 +0100, Markus Elfring wrote:
> > ParenType and FunctionType are added to the SmPL ASTs.
> > Add cases for these types in ….ml.
>
> A change description template was used several times.
> I wonder if there is really a need to modify only a single OCaml
> source file
> in these update steps.
> How do you think about to combine such changes in a bigger update
> step?
>
These are separated this way so that it's easier for Julia to review.
She will probably just squash all 26 of these together and apply them
later.
Cheers,
Jaskaran.
> Regards,
> Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Cocci] [06/26] parsing_cocci: arity: Add cases for ParenType/FunctionType
2020-03-17 5:28 ` Jaskaran Singh
@ 2020-03-17 8:40 ` Markus Elfring
2020-03-17 8:53 ` Julia Lawall
0 siblings, 1 reply; 5+ messages in thread
From: Markus Elfring @ 2020-03-17 8:40 UTC (permalink / raw)
To: Jaskaran Singh, cocci; +Cc: linux-kernel-mentees
>> How do you think about to combine such changes in a bigger update step?
>
> These are separated this way so that it's easier for Julia to review.
I suggest to reconsider such an approach.
> She will probably just squash all 26 of these together and apply them later.
I got special views also around patch squashing.
Would you like to reduce the number of update steps
according to the really desired software transformation?
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Cocci] [06/26] parsing_cocci: arity: Add cases for ParenType/FunctionType
2020-03-17 8:40 ` [Cocci] [06/26] " Markus Elfring
@ 2020-03-17 8:53 ` Julia Lawall
2020-03-17 8:57 ` Markus Elfring
0 siblings, 1 reply; 5+ messages in thread
From: Julia Lawall @ 2020-03-17 8:53 UTC (permalink / raw)
To: Markus Elfring; +Cc: linux-kernel-mentees, cocci
On Tue, 17 Mar 2020, Markus Elfring wrote:
> >> How do you think about to combine such changes in a bigger update step?
> >
> > These are separated this way so that it's easier for Julia to review.
>
> I suggest to reconsider such an approach.
>
>
> > She will probably just squash all 26 of these together and apply them later.
>
> I got special views also around patch squashing.
> Would you like to reduce the number of update steps
> according to the really desired software transformation?
I asked him to cut it up into small chunks.
julia
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-17 8:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-16 19:20 [Cocci] [PATCH 06/26] parsing_cocci: arity: Add cases for ParenType/FunctionType Markus Elfring
2020-03-17 5:28 ` Jaskaran Singh
2020-03-17 8:40 ` [Cocci] [06/26] " Markus Elfring
2020-03-17 8:53 ` Julia Lawall
2020-03-17 8:57 ` Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).