From: Evan Zhao <tacingiht@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>,
Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] Addition of do-while support for SmPL
Date: Wed, 24 Apr 2019 20:10:46 +0800 [thread overview]
Message-ID: <CAAGQS2ujUte9tX4Ai66auP8sy4zkryqEXZkbioy8+hKMvUgmMA@mail.gmail.com> (raw)
In-Reply-To: <79e7d754-f02f-d449-4090-0036274f70b5@web.de>
On Tue, Apr 23, 2019 at 12:28 AM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> > I would like to show you my efforts on adding the missing dowhile loop in SmPL.
>
> Do you refer to the functionality “do … while(…) loop” here?
>
> Thanks for your interest in software extensions according to this topic.
> https://systeme.lip6.fr/pipermail/cocci/2015-May/002030.html
> https://lore.kernel.org/cocci/5558AE29.6060407@users.sourceforge.net/
>
My patch tries to fix this issue, I was inspired by another discuss in
the kernel mailing list.
>
> > I think it's rustic and I could use your professional suggestions
>
> * How do you think about providing a more reasonable description also
> in the patch file?
>
> * I would prefer your real name in the signature.
> See also:
> https://github.com/coccinelle/coccinelle/blob/848f85e256516330c06f5fd8dc782b854ed9aa03/readme.txt#L90
>
Yes, thanks, I will fix them later.
>
> > to refine the code and complete the test set.
>
> * Would you like to add a directory for your test collection?
Hum, there are over 1000 files in tests/, it's tedious to scroll
through all of them.
>
> * Will line breaks be needed at the end of text source files?
>
I don't get this, do you mean 80 chars limitation?
Thx!
Yimin
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2019-04-24 12:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 13:34 [Cocci] [Patch] Add dowhile support in SmPL Evan Zhao
2019-04-22 16:28 ` [Cocci] Addition of do-while support for SmPL Markus Elfring
2019-04-24 12:10 ` Evan Zhao [this message]
2019-04-24 18:21 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAGQS2ujUte9tX4Ai66auP8sy4zkryqEXZkbioy8+hKMvUgmMA@mail.gmail.com \
--to=tacingiht@gmail.com \
--cc=Markus.Elfring@web.de \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).