From: Sumera Priyadarsini <sylphrenadin@gmail.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Gilles Muller <Gilles.Muller@lip6.fr>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>,
linux-kernel@vger.kernel.org, Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] [PATCH v2] scripts: coccicheck: Correct usage of make coccicheck
Date: Wed, 25 Nov 2020 01:48:42 +0530 [thread overview]
Message-ID: <CACAkLupWCKPR7knKA0YX6n+k35z653DXdhViFPfCkY3UoLyBHw@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2011232204550.2682@hadrien>
[-- Attachment #1.1: Type: text/plain, Size: 2540 bytes --]
On Tue, Nov 24, 2020 at 2:36 AM Julia Lawall <julia.lawall@inria.fr> wrote:
>
>
> On Wed, 18 Nov 2020, Sumera Priyadarsini wrote:
>
> > The command "make coccicheck C=1 CHECK=scripts/coccicheck" results in the
> > error:
> > ./scripts/coccicheck: line 65: -1: shift count out of range
> >
> > This happens because every time the C variable is specified,
> > the shell arguments need to be "shifted" in order to take only
> > the last argument, which is the C file to test. These shell arguments
> > mostly comprise flags that have been set in the Makefile. However,
> > when coccicheck is specified in the make command as a rule, the
> > number of shell arguments is zero, thus passing the invalid value -1
> > to the shift command, resulting in an error.
> >
> > Modify coccicheck to print correct usage of make coccicheck so as to
> > avoid the error.
> >
> > Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
> > ---
> > Changes in v2:
> > - Move test to only display error message
> > ---
> > scripts/coccicheck | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/scripts/coccicheck b/scripts/coccicheck
> > index 209bb0427b43..f3b8bf505c5f 100755
> > --- a/scripts/coccicheck
> > +++ b/scripts/coccicheck
> > @@ -61,6 +61,18 @@ COCCIINCLUDE=${COCCIINCLUDE// -include/ --include}
> > if [ "$C" = "1" -o "$C" = "2" ]; then
> > ONLINE=1
> >
> > + if [[ $# -le 0 ]]; then
> > + echo ''
> > + echo 'Specifying both the variable "C" and rule "coccicheck"
> in the make
> > +command results in a shift count error.'
> > + echo ''
> > + echo 'Try specifying "scripts/coccicheck" as a value for the
> CHECK variable instead.'
> > + echo ''
> > + echo 'Example: make C=2 CHECK=scripts/coccicheck
> drivers/staging/wfx/hi_t.o'
>
> I think that this file doesn't exist any more. Even though you can't
> guarantee that any particular file will be around forever, a file in
> staging is probably not a good choice, since they are usually on their way
> in or on the way out of the kernel.
>
Fair, I will send a v3 with a better example.
regards,
sumera
> julia
>
> > + echo ''
> > + exit 1
> > + fi
> > +
> > # Take only the last argument, which is the C file to test
> > shift $(( $# - 1 ))
> > OPTIONS="$COCCIINCLUDE $1"
> > --
> > 2.25.1
> >
> > _______________________________________________
> > Cocci mailing list
> > Cocci@systeme.lip6.fr
> > https://systeme.lip6.fr/mailman/listinfo/cocci
> >
>
[-- Attachment #1.2: Type: text/html, Size: 3866 bytes --]
[-- Attachment #2: Type: text/plain, Size: 136 bytes --]
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
prev parent reply other threads:[~2020-11-24 20:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 8:27 [Cocci] [PATCH v2] scripts: coccicheck: Correct usage of make coccicheck Sumera Priyadarsini
2020-11-23 21:06 ` Julia Lawall
2020-11-24 20:18 ` Sumera Priyadarsini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACAkLupWCKPR7knKA0YX6n+k35z653DXdhViFPfCkY3UoLyBHw@mail.gmail.com \
--to=sylphrenadin@gmail.com \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).