Coccinelle archive on lore.kernel.org
 help / color / Atom feed
* [Cocci] [PATCH] coccinelle: put_device: reduce false positives
@ 2019-03-23  6:14 Wen Yang
  2019-03-23 13:41 ` Julia Lawall
                   ` (2 more replies)
  0 siblings, 3 replies; 41+ messages in thread
From: Wen Yang @ 2019-03-23  6:14 UTC (permalink / raw)
  To: yamada.masahiro
  Cc: wang.yi59, Michal Marek, Nicolas Palix, linux-kernel, cocci, Wen Yang

Don't complain about a return when this function returns "&pdev->dev".

Reported-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Gilles Muller <Gilles.Muller@lip6.fr>
Cc: Nicolas Palix <nicolas.palix@imag.fr>
Cc: Michal Marek <michal.lkml@markovi.net>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
CC: cocci@systeme.lip6.fr
Cc: linux-kernel@vger.kernel.org
---
 scripts/coccinelle/free/put_device.cocci | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/coccinelle/free/put_device.cocci b/scripts/coccinelle/free/put_device.cocci
index 7395697..c9f071b 100644
--- a/scripts/coccinelle/free/put_device.cocci
+++ b/scripts/coccinelle/free/put_device.cocci
@@ -32,6 +32,7 @@ if (id == NULL || ...) { ... return ...; }
 (    id
 |    (T2)dev_get_drvdata(&id->dev)
 |    (T3)platform_get_drvdata(id)
+|    &id->dev
 );
 | return@p2 ...;
 )
-- 
2.9.5

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

^ permalink raw reply	[flat|nested] 41+ messages in thread

end of thread, back to index

Thread overview: 41+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-23  6:14 [Cocci] [PATCH] coccinelle: put_device: reduce false positives Wen Yang
2019-03-23 13:41 ` Julia Lawall
2019-03-23 19:44 ` Markus Elfring
2019-03-23 20:06   ` Julia Lawall
2019-03-26  8:45     ` Dan Carpenter
2019-03-26  9:38       ` Julia Lawall
2019-03-26 10:11         ` Dan Carpenter
2019-03-26 10:15           ` Julia Lawall
2019-03-28 13:08             ` Masahiro Yamada
2019-03-28 14:19               ` Julia Lawall
2019-04-01  6:44               ` [Cocci] Coccinelle: " Markus Elfring
2019-04-01 20:04                 ` Julia Lawall
2019-05-13  8:55 ` [Cocci] [PATCH 0/5] Coccinelle: put_device: Adjustments for a SmPL script Markus Elfring
2019-05-13  8:59   ` [Cocci] [PATCH 1/5] Coccinelle: put_device: Adjust a message construction Markus Elfring
2019-05-13  9:35     ` Julia Lawall
2019-05-13 11:33       ` [Cocci] [1/5] " Markus Elfring
2019-05-13 11:36         ` Julia Lawall
2019-05-13 12:48           ` Markus Elfring
2019-07-06 13:13     ` [Cocci] [PATCH 1/5] " Masahiro Yamada
2019-05-13  9:01   ` [Cocci] [PATCH 2/5] Coccinelle: put_device: Add a cast to an expression for an assignment Markus Elfring
2019-05-13  9:33     ` Julia Lawall
2019-07-06 13:13     ` Masahiro Yamada
2019-05-13  9:05   ` [Cocci] [PATCH 3/5] Coccinelle: put_device: Merge four SmPL when constraints into one Markus Elfring
2019-05-13  9:32     ` Julia Lawall
2019-05-13 11:48       ` [Cocci] [3/5] " Markus Elfring
2019-05-13 11:48       ` Markus Elfring
2019-05-13 11:51         ` Julia Lawall
2019-05-13 12:52           ` Markus Elfring
2019-05-13  9:07   ` [Cocci] [PATCH 4/5] Coccinelle: put_device: Extend when constraints for two SmPL ellipses Markus Elfring
2019-05-13  9:31     ` Julia Lawall
2019-05-13 12:22       ` [Cocci] [4/5] " Markus Elfring
2019-05-14  5:55       ` Markus Elfring
2019-05-14  6:52         ` Julia Lawall
2019-05-14  7:49           ` Markus Elfring
2019-05-14  9:18             ` [Cocci] [4/5] Coccinelle: put_device: Extend when constraints for twoSmPL ellipses wen.yang99
2019-05-14  9:51               ` Markus Elfring
2019-05-14  7:49           ` [Cocci] [4/5] Coccinelle: put_device: Extend when constraints for two SmPL ellipses Markus Elfring
2019-05-13  9:07   ` [Cocci] [PATCH 4/5] " Markus Elfring
2019-05-13  9:10   ` [Cocci] [PATCH 5/5] Coccinelle: put_device: Merge two SmPL when constraints into one Markus Elfring
2019-05-13  9:30     ` Julia Lawall
2019-05-13 12:35       ` [Cocci] [5/5] " Markus Elfring

Coccinelle archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/cocci/0 cocci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 cocci cocci/ https://lore.kernel.org/cocci \
		cocci@systeme.lip6.fr cocci@archiver.kernel.org
	public-inbox-index cocci

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/fr.lip6.systeme.cocci


AGPL code for this site: git clone https://public-inbox.org/ public-inbox