cocci.inria.fr archive mirror
 help / color / mirror / Atom feed
From: moustafa@cmpsamurai.com (Moustafa Mahmoud)
To: cocci@systeme.lip6.fr
Subject: [Cocci] Strange behavior with replacing multiple typedefs
Date: Sun, 16 Sep 2018 16:58:03 +0200	[thread overview]
Message-ID: <CAKCTf_YQgm-tgnsvfF6hV=sd+GjRU41XniWJqmoBFzwyDSr1-Q@mail.gmail.com> (raw)

Hello all,
I am facing this problem with typedefs, what I am trying to achieve is
convering multiple typedefs into single ones.


typedef int x,y;

into :

typedef  int x;
typedef int y;


when I try to replace them inside functions, everything works as expected\

My Rule :
@rule1@
identifier fn;
type t;
metavariable mm;
@@

++ typedef t mm;
fn(...){
<+...
- typedef t mm;
...+>
}

The C Code

typedef int;
typedef int mr,e4;

int main()
{
    typedef int sss, ssd;
}

The Diff :
diff =
--- typedef.c
+++ /tmp/cocci-output-91048-e42770-typedef.c
@@ -3,7 +3,8 @@
 typedef int;
 typedef int mr,e4;

+typedef int ssd;
+typedef int sss;
 int main()
 {
-    typedef int sss, ssd;
 }
\ No newline at end of file


However if I try to generalize it

@rule1@
type t;
metavariable mm;
@@

++ typedef t mm;
- typedef t mm;



The C Code:

typedef int;
typedef int mr,e4;

int main()
{
    typedef int sss, ssd;
}

What I get is this :

 typedef int;
-typedef int mr,e4;
+typedef int e4;
+typedef int mr;
+typedef int;

 int main()
 {
-    typedef int sss, ssd;
+    typedef int ssd;
+    typedef int sss;
+    typedef int;
 }
\ No newline at end of file


You can notice the extra  "+  typedef int;" , why are those produced ? is
there a way to achieve what  want without them ?

Thank you very much.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://systeme.lip6.fr/pipermail/cocci/attachments/20180916/4f7fbf15/attachment.html>

             reply	other threads:[~2018-09-16 14:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-16 14:58 Moustafa Mahmoud [this message]
2018-09-16 15:07 ` [Cocci] Strange behavior with replacing multiple typedefs Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKCTf_YQgm-tgnsvfF6hV=sd+GjRU41XniWJqmoBFzwyDSr1-Q@mail.gmail.com' \
    --to=moustafa@cmpsamurai.com \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).