Coccinelle Archive on lore.kernel.org
 help / color / Atom feed
From: Mansour Moufid <mansourmoufid@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: cocci <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] linux-kernel janitorial RFP: Mark static arrays as const
Date: Wed, 3 Mar 2021 12:06:12 -0500
Message-ID: <CALogXGVMCiZcMRovK+9gJVKQPDJJdWUuXRPXVZ0fxmAXyq4Uig@mail.gmail.com> (raw)
In-Reply-To: <053b06c47f08631675c295b5c893b90be4248347.camel@perches.com>

On Tue, Mar 2, 2021 at 4:22 PM Joe Perches <joe@perches.com> wrote:
>
> Here is a possible opportunity to reduce data usage in the kernel.
>
> $ git grep -P -n '^static\s+(?!const|struct)(?:\w+\s+){1,3}\w+\s*\[\s*\]' drivers/ | \
>   grep -v __initdata | \
>   wc -l
> 3250
>
> Meaning there are ~3000 declarations of arrays with what appears to be
> file static const content that are not marked const.
>
> So there are many static arrays that could be marked const to move the
> compiled object code from data to text minimizing the total amount of
> exposed r/w data.
>
> However, I do not know of a mechanism using coccinelle to determine
> whether or not any of these static declarations are ever modified.

I thought it would be a fun exercise but it got tedious quick.

I don't know how to ignore an attribute like __initdata.

Feel free to refine it:


@@
type t;
identifier x;
@@
(
    static const struct { ... } x[];
|
    static
+   const
    struct { ... } x[];
|
    static const struct s *x[];
|
    static
+   const
    struct s *x[];
|
    static const struct s x[];
|
    static
+   const
    struct s x[];
|
    static const t *x[];
|
    static
+   const
    t *x[];
|
    static const t x[];
|
    static
+   const
    t x[];
)

@@
type t;
identifier s, x, y, z;
assignment operator xx;
@@
(
    static const struct { ... } x[] = { ... };
|
    static
+   const
    struct { ... } x[] = { ... };
|
    static const struct s *x[] = { ... };
|
    static
+   const
    struct s *x[] = { ... };
|
    static const struct s x[] = { ... };
|
    static
+   const
    struct s x[] = { ... };
|
    static const t *x[] = { ... };
|
    static
+   const
    t *x[] = { ... };
|
    static const t x[] = { ... };
|
    static
+   const
    t x[] = { ... };
)
    ... when != x.y xx ...
        when != x[...] xx ...
        when != z = x
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  parent reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-02 17:42 Joe Perches
2021-03-02 21:41 ` Julia Lawall
2021-03-03  2:47   ` Joe Perches
2021-03-02 22:18 ` Bernd Petrovitsch
2021-03-03  8:36   ` Julia Lawall
2021-03-04  8:34   ` Andy Shevchenko
2021-03-03  9:41 ` Rasmus Villemoes
2021-03-03 14:51   ` Joe Perches
2021-03-07 19:14     ` Julia Lawall
2021-03-08  5:38       ` Joe Perches
2021-03-08  6:54         ` Julia Lawall
2021-03-03 17:06 ` Mansour Moufid [this message]
2021-03-03 17:21   ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALogXGVMCiZcMRovK+9gJVKQPDJJdWUuXRPXVZ0fxmAXyq4Uig@mail.gmail.com \
    --to=mansourmoufid@gmail.com \
    --cc=cocci@systeme.lip6.fr \
    --cc=joe@perches.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Coccinelle Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/cocci/0 cocci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 cocci cocci/ https://lore.kernel.org/cocci \
		cocci@systeme.lip6.fr
	public-inbox-index cocci

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/fr.lip6.systeme.cocci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git