From: Mansour Moufid <mansourmoufid@gmail.com>
To: Thomas Adam <thomas@xteddy.org>
Cc: Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] Replacing a struct member with a function call
Date: Mon, 15 Mar 2021 22:48:19 -0400 [thread overview]
Message-ID: <CALogXGW1-EbJo4_8HhtWbv02aYWgKpMwJeXuDasrsZ2HPDVJhg@mail.gmail.com> (raw)
In-Reply-To: <CAOhcEPZx4tNocG4TJvQKg_6e6kyJPbWGtj52TaGhJqHD36ZfYw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1120 bytes --]
On Sun, Mar 14, 2021, 20:43 Thomas Adam <thomas@xteddy.org> wrote:
> Hello,
>
> I can see I was as clear as mud with my explanation -- apologies for
> that, so let me try again.
>
> In my original example:
>
> struct monitor {
> struct {
> int width;
> int height
> } virtual;
> };
>
> ... the members width and height aren't required any more, as they're
> actually computable generically, and don't belong in that struct.
> Instead, I have separate functions which can provide those values.
>
> So where I have in code, statements such as:
>
> struct monitor *m = this_monitor();
> int foo = m->virutal.width;
>
> I want to be able to substitute "m->virtual.width" with a function
> call "get_width()" -- which does not involve "struct monitor" at all.
> Indeed, the semantic patch I'm trying to apply now looks like this:
>
> @@
> struct monitor *m;
> @@
>
> - m->virtual.width;
> + get_width();
>
> ... and although spatch doesn't tell me of any errors, when I run it
> over my codebase, no modifications are made. So clearly I'm still
> doing something wrong.
Remove the semi-colons. ;)
[-- Attachment #1.2: Type: text/html, Size: 1610 bytes --]
[-- Attachment #2: Type: text/plain, Size: 136 bytes --]
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2021-03-16 2:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-14 0:55 [Cocci] Replacing a struct member with a function call Thomas Adam
2021-03-14 6:10 ` Wolfram Sang
2021-03-14 9:16 ` Julia Lawall
2021-03-15 0:43 ` Thomas Adam
2021-03-15 6:38 ` Julia Lawall
2021-03-16 2:48 ` Mansour Moufid [this message]
2021-03-16 7:20 ` Julia Lawall
2021-03-18 18:19 ` Thomas Adam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALogXGW1-EbJo4_8HhtWbv02aYWgKpMwJeXuDasrsZ2HPDVJhg@mail.gmail.com \
--to=mansourmoufid@gmail.com \
--cc=cocci@systeme.lip6.fr \
--cc=thomas@xteddy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).