From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] Excluding quotes from strings of #define directives
Date: Sun, 4 Apr 2021 14:11:54 +0200 [thread overview]
Message-ID: <addb2edb-98cb-2834-b1b9-7d44cacda965@web.de> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2104041357060.2958@hadrien>
>> I hoped that the specified constraint for the metavariable “e” would mean
>> that expressions which contain a double quotation character should be excluded
>> for my source code analysis approach.
>> Would you like to check the observed software functionality once more?
>
> There is perhaps a problem, but it is surely not necessary to have all of
> this python code around it to see the problem.
I chose this test display so that it can be clearly seen which data were processes
for the metavariable “e”.
> Please make a minimal example. A rule with a match and a * in front of it should be sufficient.
Do you find constraints of the following SmPL script variant easier to clarify?
@display@
identifier i =~ "^(?:[A-Z]+_){3,3}[A-Z]+";
expression e !~ "\"";
@@
*#define i e
Test result:
https://gitlab.freedesktop.org/pipewire/pipewire/-/blob/97b01ed9b01bac7cba68ff11c6bf7ceabcae7f52/spa/include/spa/node/type-info.h#L38
elfring@Sonne:~/Projekte/PipeWire/lokal> spatch ~/Projekte/Coccinelle/janitor/show_define_usage4.cocci spa/include/spa/node/type-info.h
…
@@ -35,8 +35,6 @@ extern "C" {
#include <spa/node/event.h>
#include <spa/node/io.h>
-#define SPA_TYPE_INFO_IO SPA_TYPE_INFO_ENUM_BASE "IO"
-#define SPA_TYPE_INFO_IO_BASE SPA_TYPE_INFO_IO ":"
static const struct spa_type_info spa_type_io[] = {
{ SPA_IO_Invalid, SPA_TYPE_Int, SPA_TYPE_INFO_IO_BASE "Invalid", NULL },
…
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2021-04-05 8:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-28 7:19 [Cocci] Replacing #define directives with the help of SmPL Markus Elfring
2021-03-28 9:29 ` Julia Lawall
[not found] ` <1b5f6d22-5b89-097f-37bd-13b3b2ab011a@web.de>
2021-03-28 10:47 ` Julia Lawall
[not found] ` <173fa182-4127-aaba-262e-e3953a81a1e2@web.de>
2021-03-28 11:46 ` Julia Lawall
[not found] ` <b80fe77f-0a11-2000-522e-836c9368eaa6@web.de>
2021-03-28 12:48 ` Julia Lawall
[not found] ` <b761969f-181b-5951-0730-11c340e236ab@web.de>
2021-03-28 14:08 ` Julia Lawall
[not found] ` <f720b262-708f-a603-3470-b374db625578@web.de>
2021-03-28 14:45 ` Julia Lawall
[not found] ` <fa66fce2-e60e-1907-7c8b-fd9ceedb8086@web.de>
2021-04-04 11:58 ` [Cocci] Excluding quotes from strings of #define directives Julia Lawall
2021-04-04 12:11 ` Markus Elfring [this message]
2021-04-04 12:19 ` Julia Lawall
[not found] ` <b9f6aceb-7e68-303d-bd1e-d41a7992b58b@web.de>
2021-04-05 7:09 ` [Cocci] Checking support for compound expressions (according to #define directives) Julia Lawall
[not found] ` <8561006e-7dc6-0f62-ecf0-c93146976925@web.de>
2021-04-05 7:54 ` Julia Lawall
2021-04-05 8:46 ` Markus Elfring
2021-04-05 8:53 ` Julia Lawall
2021-04-05 10:37 ` [Cocci] Improve the handling of string literals with SmPL Markus Elfring
[not found] ` <eaa316bd-4c73-fcbb-bfad-20426348b1c2@web.de>
2021-03-28 15:17 ` [Cocci] Replacing #define directives with the help of SmPL Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=addb2edb-98cb-2834-b1b9-7d44cacda965@web.de \
--to=markus.elfring@web.de \
--cc=cocci@systeme.lip6.fr \
--cc=julia.lawall@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).