Coccinelle archive on lore.kernel.org
 help / color / Atom feed
* [Cocci] Checking data processing for clk_put.cocci
@ 2019-11-06 17:48 Markus Elfring
  0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2019-11-06 17:48 UTC (permalink / raw)
  To: Coccinelle

Hello,

I would like to clarify the following source code analysis result
which can be provided by the tool “coccicheck”.

./drivers/bus/ti-sysc.c:1776:2-8: ERROR: missing clk_put; clk_get on line 1767 and execution via conditional on line 1775
./drivers/tty/serial/bcm63xx_uart.c:851:2-8: ERROR: missing clk_put; clk_get on line 846 and execution via conditional on line 850


I have got the impression that false positives are reported for
the implementations of the functions “sysc_child_add_named_clock”
and “bcm_uart_probe” so far because variable assignment exclusions
were not specified as when constraints for the involved script
for the semantic patch language.
https://elixir.bootlin.com/linux/v5.4-rc5/source/drivers/bus/ti-sysc.c#L1784
https://elixir.bootlin.com/linux/v5.4-rc5/source/drivers/tty/serial/bcm63xx_uart.c#L811

How do you think about it?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/coccinelle/free/clk_put.cocci?id=26bc672134241a080a83b2ab9aa8abede8d30e1c#n2

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-06 17:48 [Cocci] Checking data processing for clk_put.cocci Markus Elfring

Coccinelle archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/cocci/0 cocci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 cocci cocci/ https://lore.kernel.org/cocci \
		cocci@systeme.lip6.fr
	public-inbox-index cocci

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/fr.lip6.systeme.cocci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git