cocci.inria.fr archive mirror
 help / color / mirror / Atom feed
From: julia.lawall@lip6.fr (Julia Lawall)
To: cocci@systeme.lip6.fr
Subject: [Cocci] Checking statement order for patch generation with SmPL support
Date: Thu, 7 Sep 2017 16:21:11 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1709071619340.3168@hadrien> (raw)
In-Reply-To: <c803beac-9fbe-f52d-18b5-6ef3ca3cbcb3@users.sourceforge.net>



On Thu, 7 Sep 2017, SF Markus Elfring wrote:

> >> Now I wonder why the software ?Coccinelle 1.0.6-00242-g3f038a5d? finds
> >> this place relevant when the function call sequence does not fit to the order
> >> I tried to express for a known use case.
> >> I would appreciate further advice.
> >
> > Because there is a loop,
>
> This information is appropriate.
>
> But I have got difficulties to interpret it in an useful way.


Coccinelle follows control-flow paths.  Thers is a control-flow path from
the bottom of a loop back up to the top.

>
>
> > and you did nothing to prevent an update to q because the free and the dereference.
>
> I omitted an additional constraint for a simple test.
>
>
> > @usage@
> > identifier action, member, release=~"^.+free$";
> > expression context,e;
> > @@
> > *release(context);
> >  ... when != context = e
> >      when any  // to get all results
> > *action(..., (context)->member, ...)
>
> Should the SmPL construct ?<+.. ...+>? work also similar to your suggestion?

<+... ...+> would also not allow context = e after the last match of the
pattern inside the nest.  A when on a <+... ...+> applies to the entire
matched region.

julia

  reply	other threads:[~2017-09-07 14:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-07 13:10 [Cocci] Checking statement order for patch generation with SmPL support SF Markus Elfring
2017-09-07 13:21 ` Julia Lawall
2017-09-07 13:51   ` SF Markus Elfring
2017-09-07 14:21     ` Julia Lawall [this message]
2017-09-07 14:36       ` SF Markus Elfring
2017-09-07 18:10       ` SF Markus Elfring
2017-09-07 21:26         ` Julia Lawall
2017-09-08  6:58           ` SF Markus Elfring
2017-09-08  7:15             ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1709071619340.3168@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).