From: julia.lawall@lip6.fr (Julia Lawall)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH v3] coccinelle: suggest replacing strncpy+truncation by strscpy
Date: Fri, 20 Jul 2018 07:49:59 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1807200745400.2349@hadrien> (raw)
In-Reply-To: <20180720054050.GA32233@nautica>
On Fri, 20 Jul 2018, Dominique Martinet wrote:
> Julia Lawall wrote on Fri, Jul 20, 2018:
> > > strscpy does however not clear the end of the destination buffer, so
> > > there is a risk of information leak if the full buffer is copied as is
> > > out of the kernel - this needs manual checking.
> >
> > As fasr as I can tell from lkml, only one of these patches has been
> > accepted? There was also a concern about an information leak that there
> > was no response to. Actually, I would prefer that more of the generated
> > patches are accepted before accepting the semantic patch, for something
> > that is not quite so obviously correct.
>
> As I'm pointing to the script which generated the patch in the generated
> patches, I got told that it would be better to get the coccinelle script
> accepted first, and asked others to hold on taking the patches at
> several places - I didn't resend any v2 of these with strscpy yet mostly
> for that reason.
I can't accept a semantic patch for which I can't judge the correctness.
It would be better to put a proper commit message in the individual
patches and get them accepted first.
The actual change is made by a script that is only a few lines long. You
can put those lines in your commit message if you like.
> There were concerns for information leaks that I believe I adressed in
> the specific patch that was pointed out by the concern (I might have
> missed some?), but I'll take the time to check all the patches
> individually before resending as well as filling in better commit
> messages which also was one of the main concerns.
>
> I'm however a bit stuck if I'm waiting for the cocinelle script to be
> accepted to resend the patches, but you're waiting for the individual
> patches to be accepted to take the script... :)
>
>
> I guess there is no value in the script landing first by itself, I'll
> just remove the script path from the commit messages and resend the
> first few this weekend.
It's not that there is no value to the script. The problem is that I
don't know if the script is correct - I'm not familiar with these string
functions. Once the script is in the kernel, it stays there beyond your
patches, so I would prefer to know that it is correct up front, rather
than having to remove it afterwards.
julia
next prev parent reply other threads:[~2018-07-20 5:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 1:14 [Cocci] [PATCH 01/18] coccinelle: change strncpy+truncation to strlcpy Dominique Martinet
2018-07-13 7:44 ` Himanshu Jha
2018-07-13 8:00 ` Dominique Martinet
2018-07-13 9:14 ` Himanshu Jha
2018-07-13 9:44 ` Julia Lawall
2018-07-13 10:21 ` Himanshu Jha
2018-07-13 10:50 ` Julia Lawall
2018-07-13 16:11 ` Dominique Martinet
[not found] ` <5e93dba5-1a57-ee59-e714-17a80b3fb031@users.sourceforge.net>
2018-07-13 16:42 ` [Cocci] Coccinelle: " Himanshu Jha
[not found] ` <d6fac368-bb43-f53c-0f58-b25a81156a4e@users.sourceforge.net>
2018-07-13 18:41 ` [Cocci] Coccinelle: Development challenges around software profiling Himanshu Jha
[not found] ` <536adc42-1680-e4be-bfee-7d01c37a239d@users.sourceforge.net>
2018-07-13 20:26 ` Himanshu Jha
[not found] ` <a35ae0ee-13d2-7ac8-99a4-488069983154@users.sourceforge.net>
2018-07-14 9:16 ` [Cocci] [01/18] coccinelle: change strncpy+truncation to strlcpy Dominique Martinet
2018-07-14 11:41 ` Julia Lawall
[not found] ` <4b9986b2-957a-081a-038e-afc5acf0bfdd@users.sourceforge.net>
2018-07-13 15:25 ` [Cocci] Coccinelle: " Dominique Martinet
2018-07-13 15:28 ` Julia Lawall
2018-07-14 8:12 ` [Cocci] [PATCH v2] coccinelle: strncpy+truncation by strscpy Dominique Martinet
2018-07-14 11:54 ` Julia Lawall
[not found] ` <alpine.DEB.2.20.1807140743550.3356@hadrien>
2018-07-14 13:08 ` Dominique Martinet
2018-07-14 20:36 ` Julia Lawall
2018-07-20 0:36 ` [Cocci] [PATCH v3] coccinelle: suggest replacing " Dominique Martinet
2018-07-20 5:33 ` Julia Lawall
2018-07-20 5:40 ` Dominique Martinet
2018-07-20 5:49 ` Julia Lawall [this message]
2018-07-20 5:57 ` Dominique Martinet
2018-07-20 6:03 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1807200745400.2349@hadrien \
--to=julia.lawall@lip6.fr \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).