From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38838C43387 for ; Tue, 18 Dec 2018 16:10:57 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEB9F21841 for ; Tue, 18 Dec 2018 16:10:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEB9F21841 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lip6.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/lip6) with ESMTP id wBIGAeog017584 ; Tue, 18 Dec 2018 17:10:40 +0100 (CET) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id 71F6F740A; Tue, 18 Dec 2018 17:10:40 +0100 (CET) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id 801573A55 for ; Tue, 18 Dec 2018 17:10:39 +0100 (CET) Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by isis.lip6.fr (8.15.2/lip6) with ESMTP id wBIGAcgr009162 for ; Tue, 18 Dec 2018 17:10:38 +0100 (CET) X-pt: isis.lip6.fr X-Addr-Warning: ATTENTION - Votre correspondant a fourni une adresse d'enveloppe @lip6.fr, mais ce message ne provient pas de lip6.fr ! postmaster@lip6.fr. X-IronPort-AV: E=Sophos;i="5.56,368,1539640800"; d="scan'208";a="289470009" Received: from vaio-julia.rsr.lip6.fr ([132.227.76.33]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2018 17:10:18 +0100 Date: Tue, 18 Dec 2018 17:10:10 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Max In-Reply-To: <2b642105-f754-51a0-2e8b-c9f7d439d0d5@sysmocom.de> Message-ID: References: <768d794a-e7a6-b011-f9af-5bb5a38b3c4a@sysmocom.de> <21bb981f-083a-8501-5db3-4a544f5c9646@sysmocom.de> <2b642105-f754-51a0-2e8b-c9f7d439d0d5@sysmocom.de> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary=------------63FC3239C7D214E8D3D3F151 Content-ID: X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Tue, 18 Dec 2018 17:10:40 +0100 (CET) X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Tue, 18 Dec 2018 17:10:38 +0100 (CET) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Cc: cocci@systeme.lip6.fr Subject: Re: [Cocci] replacing defines X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr --------------63FC3239C7D214E8D3D3F151 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT Content-ID: On Tue, 18 Dec 2018, Max wrote: > Attached are spatch and minimal example to reproduce the error. > > I believe that the reason is the last '}' of multiline #define. This seems > like a valid syntax to gcc but spatch gives aforementioned error. There seems to be something unanticipated about the control-flow graph of a macro definition. You can use the argument --allow-inconsistent-paths to bypass this check. julia > > Just in case ML won't accept attachements, here's how #define looks like: > > ________________ > > #define OLD(msg, data, len)                         \ >     if (msgb_func(msg) != len) {                    \ >         printf("%s:%d ERROR! with %d\n",     \ >             __func__, __LINE__, (int) len);     \ >         abort();                        \ >     } > ________________ > > > 18.12.18 16:34, Julia Lawall пишет: > > > > It's complaining about the rule starting on line 2, which is the one > > removing the #define. So the problem doesn't have anything to do with the > > two rules being together - it never starts executing the second one. > > > > Something being reachable by inconsistent control-flow paths occurs when > > if you trace through the function in one way (ie via one if branch) you > > get one transformation, and if you trace through it in another way you get > > another transformation (or no transformation). > > > > It's a bit strange that this would occur in your case, where you just want > > to remove the entire body of the #define. Can you mak a simple example > > that illustrates the problem? > > > > To figure out what #define is being considered, you can try the > > command-line argument --show-trying. If that doesn't suffice (I don't > > know to what extent it is supported for #define), then --verbose-match > > might be helpful as well. > > > > julia > > -- > - Max Suraev http://www.sysmocom.de/ > ======================================================================= > * sysmocom - systems for mobile communications GmbH > * Alt-Moabit 93 > * 10559 Berlin, Germany > * Sitz / Registered office: Berlin, HRB 134158 B > * Geschaeftsfuehrer / Managing Directors: Harald Welte > > --------------63FC3239C7D214E8D3D3F151 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci --------------63FC3239C7D214E8D3D3F151--