From: Julia Lawall <julia.lawall@lip6.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] Checking the “display” of last two statements in code blocks
Date: Fri, 12 Apr 2019 11:45:39 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1904121143510.4091@hadrien> (raw)
In-Reply-To: <8d40a536-c2fe-7d6b-58d5-840e013665f1@web.de>
[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]
On Fri, 12 Apr 2019, Markus Elfring wrote:
> Hello,
>
> I have tried another small SmPL script out.
>
>
> @display@
> identifier work;
> statement s1, s2;
> type T;
> @@
> T work(...)
> {
> ... when any
> *{
> ... when any
> * s1
> * s2
> *}
> ... when any
> }
>
>
> I have observed then that the following diff hunk was generated.
>
>
> elfring@Sonne:~/Projekte/Linux/next-patched> spatch ~/Projekte/Coccinelle/janitor/show_last_two_statements_in_a_block.cocci drivers/net/ethernet/ti/netcp_ethss.c|less
> …
> @@ -3015,11 +2859,6 @@ static int init_slave(struct gbe_priv *g
> }
>
> if (of_property_read_u32(node, "link-interface",
> - &slave->link_interface)) {
> - dev_warn(gbe_dev->dev,
> - "missing link-interface value defaulting to 1G mac-phy link\n");
> - slave->link_interface = SGMII_LINK_MAC_PHY;
> - }
>
> slave->node = node;
> slave->open = false;
> …
>
>
> Now I wonder about the suggested change for the if statement here.
> Should any more software adjustments be considered so that it will be avoided
> to delete only a questionable part from a function call within a condition check?
I don't understand the problem. You put *s on the { } and two statements,
and you get - on the lines that contain the { } and the two statements.
Nothing is being deleted anyway. The -s are just a concise way to
indicate the lines on which you requested a match with the *s. If you
want something more fine grained, use position variables and implement the
display you want in python code.
julia
>
> Regards,
> Markus
> _______________________________________________
> Cocci mailing list
> Cocci@systeme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci
>
[-- Attachment #2: Type: text/plain, Size: 136 bytes --]
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2019-04-12 9:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 9:42 [Cocci] Checking the “display” of last two statements in code blocks Markus Elfring
2019-04-12 9:45 ` Julia Lawall [this message]
2019-04-12 10:28 ` Markus Elfring
2019-04-12 10:32 ` Julia Lawall
2019-04-12 10:42 ` [Cocci] Clarification for SmPL asterisk functionality Markus Elfring
2019-04-18 10:00 ` [Cocci] Searching for last two statements in code blocks Markus Elfring
2019-10-22 15:19 ` Markus Elfring
2019-04-19 12:14 ` [Cocci] Checking the search for duplicate statements at the end of if branches Markus Elfring
2019-04-20 7:30 ` [Cocci] Checking execution environment for Python code in SmPL scripts Markus Elfring
2019-04-20 7:35 ` Julia Lawall
2019-04-20 7:51 ` Markus Elfring
2019-04-20 8:05 ` Julia Lawall
2019-04-20 8:11 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1904121143510.4091@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Markus.Elfring@web.de \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).