From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF393C04AB1 for ; Mon, 13 May 2019 09:39:18 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 731432146F for ; Mon, 13 May 2019 09:39:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 731432146F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lip6.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/lip6) with ESMTP id x4D9ct4g028364 ; Mon, 13 May 2019 11:38:55 +0200 (CEST) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id DD2BB773E; Mon, 13 May 2019 11:38:54 +0200 (CEST) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id 20ECB770C for ; Mon, 13 May 2019 11:38:52 +0200 (CEST) Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by isis.lip6.fr (8.15.2/lip6) with ESMTP id x4D9cngu021998 for ; Mon, 13 May 2019 11:38:49 +0200 (CEST) X-pt: isis.lip6.fr X-Addr-Warning: ATTENTION - Votre correspondant a fourni une adresse d'enveloppe @lip6.fr, mais ce message ne provient pas de lip6.fr ! postmaster@lip6.fr. X-IronPort-AV: E=Sophos;i="5.60,465,1549926000"; d="scan'208";a="382868419" Received: from vaio-julia.rsr.lip6.fr ([132.227.76.33]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 May 2019 11:35:44 +0200 Date: Mon, 13 May 2019 11:35:40 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Markus Elfring In-Reply-To: <308f5571-68f3-7505-d5ad-59ee68091959@web.de> Message-ID: References: <1553321671-27749-1-git-send-email-wen.yang99@zte.com.cn> <308f5571-68f3-7505-d5ad-59ee68091959@web.de> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Mon, 13 May 2019 11:38:56 +0200 (CEST) X-Greylist: Delayed for 00:08:18 by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Mon, 13 May 2019 11:38:49 +0200 (CEST) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Cc: Yi Wang , Michal Marek , Nicolas Palix , linux-kernel@vger.kernel.org, Wen Yang , cocci@systeme.lip6.fr Subject: Re: [Cocci] [PATCH 1/5] Coccinelle: put_device: Adjust a message construction X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr On Mon, 13 May 2019, Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 7 May 2019 11:20:48 +0200 > > The Linux coding style tolerates long string literals so that > the provided information can be easier found also by search tools > like grep. > Thus simplify a message construction in a SmPL rule by concatenating text > with two plus operators less. I don't know python very well. Is there any way to unindent, so that the string doesn't exceed 80 characters, or at least no so much? On the other hand, I would have much preferred the original msg = code. I don't understand why it is so offensive. julia > > Signed-off-by: Markus Elfring > --- > scripts/coccinelle/free/put_device.cocci | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/scripts/coccinelle/free/put_device.cocci b/scripts/coccinelle/free/put_device.cocci > index c9f071b0a0ab..3ebebc064f10 100644 > --- a/scripts/coccinelle/free/put_device.cocci > +++ b/scripts/coccinelle/free/put_device.cocci > @@ -42,11 +42,10 @@ p1 << search.p1; > p2 << search.p2; > @@ > > -coccilib.report.print_report(p2[0], "ERROR: missing put_device; " > - + "call of_find_device_by_node on line " > - + p1[0].line > - + ", but without a corresponding object release " > - + "within this function.") > +coccilib.report.print_report(p2[0], > + "ERROR: missing put_device; call of_find_device_by_node on line " > + + p1[0].line > + + ", but without a corresponding object release within this function.") > > @script:python depends on org@ > p1 << search.p1; > -- > 2.21.0 > > _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci