From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ABC8C04AA7 for ; Mon, 13 May 2019 11:51:59 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C91C2085A for ; Mon, 13 May 2019 11:51:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C91C2085A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lip6.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/lip6) with ESMTP id x4DBpmIM002835 ; Mon, 13 May 2019 13:51:48 +0200 (CEST) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id 04F5F7751; Mon, 13 May 2019 13:51:48 +0200 (CEST) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id 6E084773E for ; Mon, 13 May 2019 13:51:45 +0200 (CEST) Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by isis.lip6.fr (8.15.2/lip6) with ESMTP id x4DBpi7W028852 for ; Mon, 13 May 2019 13:51:44 +0200 (CEST) X-pt: isis.lip6.fr X-Addr-Warning: ATTENTION - Votre correspondant a fourni une adresse d'enveloppe @lip6.fr, mais ce message ne provient pas de lip6.fr ! postmaster@lip6.fr. X-IronPort-AV: E=Sophos;i="5.60,465,1549926000"; d="scan'208";a="305811236" Received: from vaio-julia.rsr.lip6.fr ([132.227.76.33]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 May 2019 13:51:44 +0200 Date: Mon, 13 May 2019 13:51:39 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Markus Elfring In-Reply-To: <1c36d747-ac2d-0187-ddb7-d1a2bb18ddaf@web.de> Message-ID: References: <1553321671-27749-1-git-send-email-wen.yang99@zte.com.cn> <6b62ecb5-ab88-22d9-eee2-db4f58b6d2ae@web.de> <1c36d747-ac2d-0187-ddb7-d1a2bb18ddaf@web.de> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Mon, 13 May 2019 13:51:48 +0200 (CEST) X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Mon, 13 May 2019 13:51:44 +0200 (CEST) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Cc: Yi Wang , Michal Marek , Nicolas Palix , linux-kernel@vger.kernel.org, Wen Yang , cocci@systeme.lip6.fr Subject: Re: [Cocci] [3/5] Coccinelle: put_device: Merge four SmPL when constraints into one X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr On Mon, 13 May 2019, Markus Elfring wrote: > >> An assignment target was repeated in four SmPL when constraints. > >> Combine the exclusion specifications into disjunctions for the semantic > >> patch language so that this target is referenced only once there. > > > > NACK. > > I find this rejection questionable. > > > > This exceeds 80 characters > > The line became 105 characters long. > 14 space characters can eventually be omitted. > > > > and provides no readability benefit. > > I try to stress SmPL functionality in this use case. That's not the goal of the semantic patches in the kernel. The rule is fine as it is. > >> +++ b/scripts/coccinelle/free/put_device.cocci > >> @@ -23,10 +23,7 @@ if (id == NULL || ...) { ... return ...; } > >> when != platform_device_put(id) > >> when != of_dev_put(id) > >> when != if (id) { ... put_device(&id->dev) ... } > >> - when != e1 = (T)id > >> - when != e1 = (T)(&id->dev) > >> - when != e1 = get_device(&id->dev) > >> - when != e1 = (T1)platform_get_drvdata(id) > >> + when != e1 = \( (T) \( id \| (&id->dev) \) \| get_device(&id->dev) \| (T1)platform_get_drvdata(id) \) > > How do you think about to extend the Coccinelle software in the way > that such a detailed constraint can be specified on separate lines > (without duplicated SmPL code)? This causes some ambiguities in the parser. No change is likely to occur here. julia > > How long will it take to reconsider corresponding software limitations? > > Regards, > Markus > _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci