From: julia.lawall@lip6.fr (Julia Lawall)
To: cocci@systeme.lip6.fr
Subject: [Cocci] First coccinelle script, need some help.
Date: Wed, 10 Oct 2018 23:12:26 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1810102312010.2479@hadrien> (raw)
In-Reply-To: <20181010211125.GA128537@joelaf.mtv.corp.google.com>
On Wed, 10 Oct 2018, Joel Fernandes wrote:
> On Wed, Oct 10, 2018 at 10:51:28PM +0200, Julia Lawall wrote:
> >
> >
> > On Wed, 10 Oct 2018, Joel Fernandes wrote:
> >
> > > On Wed, Oct 10, 2018 at 10:23:18PM +0200, Julia Lawall wrote:
> > > >
> > > >
> > > > On Wed, 10 Oct 2018, Joel Fernandes wrote:
> > > >
> > > > >
> > > > > Hi!
> > > > >
> > > > > I am trying to determine if a function argument is used across the whole
> > > > > kernel for a certain kernel function.
> > > > >
> > > > > I mustered up enough courage to write my first coccinelle script after a few
> > > > > late nights of reading up about it :)
> > > > >
> > > > > Here is .cocci script. I am trying to find if address is used at all in any
> > > > > possible definitions of pte_alloc():
> > > > >
> > > > > $ cat ~/pte_alloc.cocci
> > > > > virtual report
> > > > >
> > > > > @pte_args depends on report@
> > > > > identifier E1, E2;
> > > > > type T1, T2;
> > > > > position p;
> > > > > @@
> > > > >
> > > > > pte_alloc at p(T1 E1, T2 E2)
> > > > > {
> > > > > ...
> > > > > (
> > > > > ...
> > > > > E2
> > > > > ...
> > > > > )
> > > > > ...
> > > > > }
> > > >
> > > >
> > > > In report mode, by default, the pattern has to match on all paths. Also
> > > > when you have ... before or after E2, there can be no occurrence of E2 in
> > > > the code matched by the ... So your rule requires that on every possible
> > > > execution path through the function, there is exactly one occurrence of
> > > > E2.
> > > >
> > > > You can try the following instead:
> > > >
> > > > virtual report
> > > >
> > > > @pte_args depends on report exists@
> > > > identifier E1, E2;
> > > > type T1, T2;
> > > > position p;
> > > > @@
> > > >
> > > > pte_alloc at p(T1 E1, T2 E2)
> > > > {
> > > > ... when any
> > > > E2
> > > > ... when any
> > > > }
> > >
> > > Thanks for the quick reply.
> > > If I just add 'depends on report exists' to the rule, then my original
> > > example works fine now. I did not need to add the 'when any'. Do you mind
> > > taking my original simple test.c example and modify it and let me know under
> > > what situation would it not work?
> > >
> > > I even added address = 1 outside of the if block and it works fine, I see the
> > > warning as I expect without 'when any' in pront of the "...".
> > >
> > > struct page *pte_alloc(struct mm_struct *mm, unsigned long address)
> > > {
> > > address = 1;
> > > if (condition()) {
> > > while (1) {
> > > address++;
> > > }
> > > return NULL;
> > > }
> > > }
> >
> > This works, because there exists a path through the function that has only
> > one use of address, ie the path where condition() is false. It should
> > break if you put address = 2; just under address = 1, for example.
> >
> Ok, thanks. This fact really is a bit subtle I'd say but hopefully will not
> be once I get past the learning curve. Interestingly, if I do the following
> then that works too without needing 'exists':
>
> virtual report
>
> @pte_args depends on report@
> identifier E1, E2;
> type T1, T2;
> position p;
> @@
>
> pte_alloc at p(T1 E1, T2 E2)
> {
> <+...
> E2
> ...+>
> }
>
> @script:python depends on report@
> p << pte_args.p;
> @@
> coccilib.report.print_report(p[0], "WARNING: found definition of pte_alloc with
> address used in the body")
Yes, that is another option. But it may be more expensive.
julia
next prev parent reply other threads:[~2018-10-10 21:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 19:38 [Cocci] First coccinelle script, need some help Joel Fernandes
2018-10-10 20:23 ` Julia Lawall
2018-10-10 20:45 ` Joel Fernandes
2018-10-10 20:51 ` Julia Lawall
2018-10-10 21:11 ` Joel Fernandes
2018-10-10 21:12 ` Julia Lawall [this message]
[not found] ` <93da55ff-c807-6587-7ef3-3d2af820117d@users.sourceforge.net>
2018-10-11 15:43 ` [Cocci] Searching for parameter usages of pte_alloc() Joel Fernandes
2018-10-11 15:51 ` Julia Lawall
2018-10-11 16:28 ` Joel Fernandes
2018-10-11 16:40 ` Julia Lawall
2018-10-11 16:49 ` Joel Fernandes
2018-10-11 16:57 ` Julia Lawall
2018-10-11 17:06 ` Joel Fernandes
2018-10-11 18:06 ` Joel Fernandes
2018-10-11 18:07 ` Joel Fernandes
[not found] ` <cd2eb29e-775f-9c48-b839-b2ebdc3e3c56@users.sourceforge.net>
2018-10-11 23:54 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1810102312010.2479@hadrien \
--to=julia.lawall@lip6.fr \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).