Coccinelle archive on lore.kernel.org
 help / Atom feed
* [Cocci] sending out trewide patches
@ 2018-10-27  6:38 julia.lawall
  2018-10-27 17:14 ` paulmck
  0 siblings, 1 reply; 10+ messages in thread
From: julia.lawall @ 2018-10-27  6:38 UTC (permalink / raw)
  To: cocci

Hello,

At OSS Europe, I got some questions about how to send out large
Coccinelle-generated patches.  Coccinelle provides a tool tools/splitpatch
(go to the tools subdirectory of the Coccinelle distribution and run make)
that splits patches by set of maintainers (the default), by directory
(--dirmerge option), or by file (--nomerge option).  There is a file
tools/splitpatch.README that explains the various ways that it can be
used, but the simplest is to create a patch normally using
git format-patch -s, obtaining eg 0001-changes.patch, and then run

splitpatch 0001-changes.patch

The output will include a 0001-changes.cover file, a set of
0001-changesN.patch files with the various split patches, and a
0001-changes.cmd file for sending it off with git send-email.

This is available in the latest github version of Coccinelle.  Comments
are welcome.

julia

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Cocci] sending out trewide patches
  2018-10-27  6:38 [Cocci] sending out trewide patches julia.lawall
@ 2018-10-27 17:14 ` paulmck
  2018-10-27 18:08   ` julia.lawall
  0 siblings, 1 reply; 10+ messages in thread
From: paulmck @ 2018-10-27 17:14 UTC (permalink / raw)
  To: cocci

On Sat, Oct 27, 2018 at 08:38:02AM +0200, Julia Lawall wrote:
> Hello,
> 
> At OSS Europe, I got some questions about how to send out large
> Coccinelle-generated patches.  Coccinelle provides a tool tools/splitpatch
> (go to the tools subdirectory of the Coccinelle distribution and run make)
> that splits patches by set of maintainers (the default), by directory
> (--dirmerge option), or by file (--nomerge option).  There is a file
> tools/splitpatch.README that explains the various ways that it can be
> used, but the simplest is to create a patch normally using
> git format-patch -s, obtaining eg 0001-changes.patch, and then run
> 
> splitpatch 0001-changes.patch
> 
> The output will include a 0001-changes.cover file, a set of
> 0001-changesN.patch files with the various split patches, and a
> 0001-changes.cmd file for sending it off with git send-email.
> 
> This is available in the latest github version of Coccinelle.  Comments
> are welcome.

Thank you, Julia!  I will give it a try.

							Thanx, Paul

PS.  And in case you didn't make it there...  ;-)

	https://www.spatchchicken.co.uk/
	https://www.spatchchicken.co.uk/about-us.html

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Cocci] sending out trewide patches
  2018-10-27 17:14 ` paulmck
@ 2018-10-27 18:08   ` julia.lawall
  2018-10-30 19:45     ` paulmck
  0 siblings, 1 reply; 10+ messages in thread
From: julia.lawall @ 2018-10-27 18:08 UTC (permalink / raw)
  To: cocci



On Sat, 27 Oct 2018, Paul E. McKenney wrote:

> On Sat, Oct 27, 2018 at 08:38:02AM +0200, Julia Lawall wrote:
> > Hello,
> >
> > At OSS Europe, I got some questions about how to send out large
> > Coccinelle-generated patches.  Coccinelle provides a tool tools/splitpatch
> > (go to the tools subdirectory of the Coccinelle distribution and run make)
> > that splits patches by set of maintainers (the default), by directory
> > (--dirmerge option), or by file (--nomerge option).  There is a file
> > tools/splitpatch.README that explains the various ways that it can be
> > used, but the simplest is to create a patch normally using
> > git format-patch -s, obtaining eg 0001-changes.patch, and then run
> >
> > splitpatch 0001-changes.patch
> >
> > The output will include a 0001-changes.cover file, a set of
> > 0001-changesN.patch files with the various split patches, and a
> > 0001-changes.cmd file for sending it off with git send-email.
> >
> > This is available in the latest github version of Coccinelle.  Comments
> > are welcome.
>
> Thank you, Julia!  I will give it a try.
>
> 							Thanx, Paul
>
> PS.  And in case you didn't make it there...  ;-)
>
> 	https://www.spatchchicken.co.uk/
> 	https://www.spatchchicken.co.uk/about-us.html

Amazing.  Thanks!

julia

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Cocci] sending out trewide patches
  2018-10-27 18:08   ` julia.lawall
@ 2018-10-30 19:45     ` paulmck
  2018-10-30 19:56       ` julia.lawall
  0 siblings, 1 reply; 10+ messages in thread
From: paulmck @ 2018-10-30 19:45 UTC (permalink / raw)
  To: cocci

On Sat, Oct 27, 2018 at 08:08:33PM +0200, Julia Lawall wrote:
> 
> 
> On Sat, 27 Oct 2018, Paul E. McKenney wrote:
> 
> > On Sat, Oct 27, 2018 at 08:38:02AM +0200, Julia Lawall wrote:
> > > Hello,
> > >
> > > At OSS Europe, I got some questions about how to send out large
> > > Coccinelle-generated patches.  Coccinelle provides a tool tools/splitpatch
> > > (go to the tools subdirectory of the Coccinelle distribution and run make)
> > > that splits patches by set of maintainers (the default), by directory
> > > (--dirmerge option), or by file (--nomerge option).  There is a file
> > > tools/splitpatch.README that explains the various ways that it can be
> > > used, but the simplest is to create a patch normally using
> > > git format-patch -s, obtaining eg 0001-changes.patch, and then run
> > >
> > > splitpatch 0001-changes.patch
> > >
> > > The output will include a 0001-changes.cover file, a set of
> > > 0001-changesN.patch files with the various split patches, and a
> > > 0001-changes.cmd file for sending it off with git send-email.
> > >
> > > This is available in the latest github version of Coccinelle.  Comments
> > > are welcome.
> >
> > Thank you, Julia!  I will give it a try.

Does the following error message mean that I need a more up-to-date
version of ocaml or some such?

							Thanx, Paul

File "globals/config.ml", line 1:
Error: The implementation globals/config.ml
       does not match the interface globals/config.cmi:
       The field `python_interpreter' is required but not provided
       The field `ocaml_version' is required but not provided
       The field `configure_flags' is required but not provided
       The field `get_temp_dir_name' is required but not provided
make: *** [globals/config.cmo] Error 2

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Cocci] sending out trewide patches
  2018-10-30 19:45     ` paulmck
@ 2018-10-30 19:56       ` julia.lawall
  2018-10-30 20:04         ` paulmck
  0 siblings, 1 reply; 10+ messages in thread
From: julia.lawall @ 2018-10-30 19:56 UTC (permalink / raw)
  To: cocci



On Tue, 30 Oct 2018, Paul E. McKenney wrote:

> On Sat, Oct 27, 2018 at 08:08:33PM +0200, Julia Lawall wrote:
> >
> >
> > On Sat, 27 Oct 2018, Paul E. McKenney wrote:
> >
> > > On Sat, Oct 27, 2018 at 08:38:02AM +0200, Julia Lawall wrote:
> > > > Hello,
> > > >
> > > > At OSS Europe, I got some questions about how to send out large
> > > > Coccinelle-generated patches.  Coccinelle provides a tool tools/splitpatch
> > > > (go to the tools subdirectory of the Coccinelle distribution and run make)
> > > > that splits patches by set of maintainers (the default), by directory
> > > > (--dirmerge option), or by file (--nomerge option).  There is a file
> > > > tools/splitpatch.README that explains the various ways that it can be
> > > > used, but the simplest is to create a patch normally using
> > > > git format-patch -s, obtaining eg 0001-changes.patch, and then run
> > > >
> > > > splitpatch 0001-changes.patch
> > > >
> > > > The output will include a 0001-changes.cover file, a set of
> > > > 0001-changesN.patch files with the various split patches, and a
> > > > 0001-changes.cmd file for sending it off with git send-email.
> > > >
> > > > This is available in the latest github version of Coccinelle.  Comments
> > > > are welcome.
> > >
> > > Thank you, Julia!  I will give it a try.
>
> Does the following error message mean that I need a more up-to-date
> version of ocaml or some such?
>
> 							Thanx, Paul
>
> File "globals/config.ml", line 1:
> Error: The implementation globals/config.ml
>        does not match the interface globals/config.cmi:
>        The field `python_interpreter' is required but not provided
>        The field `ocaml_version' is required but not provided
>        The field `configure_flags' is required but not provided
>        The field `get_temp_dir_name' is required but not provided
> make: *** [globals/config.cmo] Error 2

I'm not familiar with that.  I assume you started with the github version
of Coccinelle.  Then ./autogen and ./configure.  Then make.  A recent
version of OCaml would indeed be good.  Maybe running make distclean
before ./autogen would be good.  The inconsistencies suggest that you have
some old compiled code hanging around.  The build infrastructure has
changed a lot recently, so it might not be managing code that predates the
changes in a way that you would expect.

julia

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Cocci] sending out trewide patches
  2018-10-30 19:56       ` julia.lawall
@ 2018-10-30 20:04         ` paulmck
  2018-10-30 20:09           ` julia.lawall
  0 siblings, 1 reply; 10+ messages in thread
From: paulmck @ 2018-10-30 20:04 UTC (permalink / raw)
  To: cocci

On Tue, Oct 30, 2018 at 08:56:01PM +0100, Julia Lawall wrote:
> 
> 
> On Tue, 30 Oct 2018, Paul E. McKenney wrote:
> 
> > On Sat, Oct 27, 2018 at 08:08:33PM +0200, Julia Lawall wrote:
> > >
> > >
> > > On Sat, 27 Oct 2018, Paul E. McKenney wrote:
> > >
> > > > On Sat, Oct 27, 2018 at 08:38:02AM +0200, Julia Lawall wrote:
> > > > > Hello,
> > > > >
> > > > > At OSS Europe, I got some questions about how to send out large
> > > > > Coccinelle-generated patches.  Coccinelle provides a tool tools/splitpatch
> > > > > (go to the tools subdirectory of the Coccinelle distribution and run make)
> > > > > that splits patches by set of maintainers (the default), by directory
> > > > > (--dirmerge option), or by file (--nomerge option).  There is a file
> > > > > tools/splitpatch.README that explains the various ways that it can be
> > > > > used, but the simplest is to create a patch normally using
> > > > > git format-patch -s, obtaining eg 0001-changes.patch, and then run
> > > > >
> > > > > splitpatch 0001-changes.patch
> > > > >
> > > > > The output will include a 0001-changes.cover file, a set of
> > > > > 0001-changesN.patch files with the various split patches, and a
> > > > > 0001-changes.cmd file for sending it off with git send-email.
> > > > >
> > > > > This is available in the latest github version of Coccinelle.  Comments
> > > > > are welcome.
> > > >
> > > > Thank you, Julia!  I will give it a try.
> >
> > Does the following error message mean that I need a more up-to-date
> > version of ocaml or some such?
> >
> > 							Thanx, Paul
> >
> > File "globals/config.ml", line 1:
> > Error: The implementation globals/config.ml
> >        does not match the interface globals/config.cmi:
> >        The field `python_interpreter' is required but not provided
> >        The field `ocaml_version' is required but not provided
> >        The field `configure_flags' is required but not provided
> >        The field `get_temp_dir_name' is required but not provided
> > make: *** [globals/config.cmo] Error 2
> 
> I'm not familiar with that.  I assume you started with the github version
> of Coccinelle.  Then ./autogen and ./configure.  Then make.  A recent
> version of OCaml would indeed be good.  Maybe running make distclean
> before ./autogen would be good.  The inconsistencies suggest that you have
> some old compiled code hanging around.  The build infrastructure has
> changed a lot recently, so it might not be managing code that predates the
> changes in a way that you would expect.

Good point, that does work much better.  Now -this- error message
seems to be me having an old ocaml:

ocamlfind ocamlopt -c  -no-alias-deps stdcompat__weak.mli -o stdcompat__weak.cmi
ocamlopt: unknown option `-no-alias-deps'.

Will get a new one and see how it goes...  ;-)

							Thanx, Paul

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Cocci] sending out trewide patches
  2018-10-30 20:04         ` paulmck
@ 2018-10-30 20:09           ` julia.lawall
  2018-10-30 20:35             ` paulmck
  0 siblings, 1 reply; 10+ messages in thread
From: julia.lawall @ 2018-10-30 20:09 UTC (permalink / raw)
  To: cocci



On Tue, 30 Oct 2018, Paul E. McKenney wrote:

> On Tue, Oct 30, 2018 at 08:56:01PM +0100, Julia Lawall wrote:
> >
> >
> > On Tue, 30 Oct 2018, Paul E. McKenney wrote:
> >
> > > On Sat, Oct 27, 2018 at 08:08:33PM +0200, Julia Lawall wrote:
> > > >
> > > >
> > > > On Sat, 27 Oct 2018, Paul E. McKenney wrote:
> > > >
> > > > > On Sat, Oct 27, 2018 at 08:38:02AM +0200, Julia Lawall wrote:
> > > > > > Hello,
> > > > > >
> > > > > > At OSS Europe, I got some questions about how to send out large
> > > > > > Coccinelle-generated patches.  Coccinelle provides a tool tools/splitpatch
> > > > > > (go to the tools subdirectory of the Coccinelle distribution and run make)
> > > > > > that splits patches by set of maintainers (the default), by directory
> > > > > > (--dirmerge option), or by file (--nomerge option).  There is a file
> > > > > > tools/splitpatch.README that explains the various ways that it can be
> > > > > > used, but the simplest is to create a patch normally using
> > > > > > git format-patch -s, obtaining eg 0001-changes.patch, and then run
> > > > > >
> > > > > > splitpatch 0001-changes.patch
> > > > > >
> > > > > > The output will include a 0001-changes.cover file, a set of
> > > > > > 0001-changesN.patch files with the various split patches, and a
> > > > > > 0001-changes.cmd file for sending it off with git send-email.
> > > > > >
> > > > > > This is available in the latest github version of Coccinelle.  Comments
> > > > > > are welcome.
> > > > >
> > > > > Thank you, Julia!  I will give it a try.
> > >
> > > Does the following error message mean that I need a more up-to-date
> > > version of ocaml or some such?
> > >
> > > 							Thanx, Paul
> > >
> > > File "globals/config.ml", line 1:
> > > Error: The implementation globals/config.ml
> > >        does not match the interface globals/config.cmi:
> > >        The field `python_interpreter' is required but not provided
> > >        The field `ocaml_version' is required but not provided
> > >        The field `configure_flags' is required but not provided
> > >        The field `get_temp_dir_name' is required but not provided
> > > make: *** [globals/config.cmo] Error 2
> >
> > I'm not familiar with that.  I assume you started with the github version
> > of Coccinelle.  Then ./autogen and ./configure.  Then make.  A recent
> > version of OCaml would indeed be good.  Maybe running make distclean
> > before ./autogen would be good.  The inconsistencies suggest that you have
> > some old compiled code hanging around.  The build infrastructure has
> > changed a lot recently, so it might not be managing code that predates the
> > changes in a way that you would expect.
>
> Good point, that does work much better.  Now -this- error message
> seems to be me having an old ocaml:
>
> ocamlfind ocamlopt -c  -no-alias-deps stdcompat__weak.mli -o stdcompat__weak.cmi
> ocamlopt: unknown option `-no-alias-deps'.
>
> Will get a new one and see how it goes...  ;-)

What version do you have?  I thought that the makefile would detect
unsupported versions, so perhaps that check needs to be improved.

julia

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Cocci] sending out trewide patches
  2018-10-30 20:09           ` julia.lawall
@ 2018-10-30 20:35             ` paulmck
  2018-10-30 20:54               ` paulmck
  0 siblings, 1 reply; 10+ messages in thread
From: paulmck @ 2018-10-30 20:35 UTC (permalink / raw)
  To: cocci

On Tue, Oct 30, 2018 at 09:09:27PM +0100, Julia Lawall wrote:
> 
> 
> On Tue, 30 Oct 2018, Paul E. McKenney wrote:
> 
> > On Tue, Oct 30, 2018 at 08:56:01PM +0100, Julia Lawall wrote:
> > >
> > >
> > > On Tue, 30 Oct 2018, Paul E. McKenney wrote:
> > >
> > > > On Sat, Oct 27, 2018 at 08:08:33PM +0200, Julia Lawall wrote:
> > > > >
> > > > >
> > > > > On Sat, 27 Oct 2018, Paul E. McKenney wrote:
> > > > >
> > > > > > On Sat, Oct 27, 2018 at 08:38:02AM +0200, Julia Lawall wrote:
> > > > > > > Hello,
> > > > > > >
> > > > > > > At OSS Europe, I got some questions about how to send out large
> > > > > > > Coccinelle-generated patches.  Coccinelle provides a tool tools/splitpatch
> > > > > > > (go to the tools subdirectory of the Coccinelle distribution and run make)
> > > > > > > that splits patches by set of maintainers (the default), by directory
> > > > > > > (--dirmerge option), or by file (--nomerge option).  There is a file
> > > > > > > tools/splitpatch.README that explains the various ways that it can be
> > > > > > > used, but the simplest is to create a patch normally using
> > > > > > > git format-patch -s, obtaining eg 0001-changes.patch, and then run
> > > > > > >
> > > > > > > splitpatch 0001-changes.patch
> > > > > > >
> > > > > > > The output will include a 0001-changes.cover file, a set of
> > > > > > > 0001-changesN.patch files with the various split patches, and a
> > > > > > > 0001-changes.cmd file for sending it off with git send-email.
> > > > > > >
> > > > > > > This is available in the latest github version of Coccinelle.  Comments
> > > > > > > are welcome.
> > > > > >
> > > > > > Thank you, Julia!  I will give it a try.
> > > >
> > > > Does the following error message mean that I need a more up-to-date
> > > > version of ocaml or some such?
> > > >
> > > > 							Thanx, Paul
> > > >
> > > > File "globals/config.ml", line 1:
> > > > Error: The implementation globals/config.ml
> > > >        does not match the interface globals/config.cmi:
> > > >        The field `python_interpreter' is required but not provided
> > > >        The field `ocaml_version' is required but not provided
> > > >        The field `configure_flags' is required but not provided
> > > >        The field `get_temp_dir_name' is required but not provided
> > > > make: *** [globals/config.cmo] Error 2
> > >
> > > I'm not familiar with that.  I assume you started with the github version
> > > of Coccinelle.  Then ./autogen and ./configure.  Then make.  A recent
> > > version of OCaml would indeed be good.  Maybe running make distclean
> > > before ./autogen would be good.  The inconsistencies suggest that you have
> > > some old compiled code hanging around.  The build infrastructure has
> > > changed a lot recently, so it might not be managing code that predates the
> > > changes in a way that you would expect.
> >
> > Good point, that does work much better.  Now -this- error message
> > seems to be me having an old ocaml:
> >
> > ocamlfind ocamlopt -c  -no-alias-deps stdcompat__weak.mli -o stdcompat__weak.cmi
> > ocamlopt: unknown option `-no-alias-deps'.
> >
> > Will get a new one and see how it goes...  ;-)
> 
> What version do you have?  I thought that the makefile would detect
> unsupported versions, so perhaps that check needs to be improved.

I am running 4.0.3 and now installing 4.0.5.

							Thanx, Paul

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Cocci] sending out trewide patches
  2018-10-30 20:35             ` paulmck
@ 2018-10-30 20:54               ` paulmck
  2018-10-30 21:11                 ` julia.lawall
  0 siblings, 1 reply; 10+ messages in thread
From: paulmck @ 2018-10-30 20:54 UTC (permalink / raw)
  To: cocci

On Tue, Oct 30, 2018 at 01:35:33PM -0700, Paul E. McKenney wrote:
> On Tue, Oct 30, 2018 at 09:09:27PM +0100, Julia Lawall wrote:
> > 
> > 
> > On Tue, 30 Oct 2018, Paul E. McKenney wrote:
> > 
> > > On Tue, Oct 30, 2018 at 08:56:01PM +0100, Julia Lawall wrote:
> > > >
> > > >
> > > > On Tue, 30 Oct 2018, Paul E. McKenney wrote:
> > > >
> > > > > On Sat, Oct 27, 2018 at 08:08:33PM +0200, Julia Lawall wrote:
> > > > > >
> > > > > >
> > > > > > On Sat, 27 Oct 2018, Paul E. McKenney wrote:
> > > > > >
> > > > > > > On Sat, Oct 27, 2018 at 08:38:02AM +0200, Julia Lawall wrote:
> > > > > > > > Hello,
> > > > > > > >
> > > > > > > > At OSS Europe, I got some questions about how to send out large
> > > > > > > > Coccinelle-generated patches.  Coccinelle provides a tool tools/splitpatch
> > > > > > > > (go to the tools subdirectory of the Coccinelle distribution and run make)
> > > > > > > > that splits patches by set of maintainers (the default), by directory
> > > > > > > > (--dirmerge option), or by file (--nomerge option).  There is a file
> > > > > > > > tools/splitpatch.README that explains the various ways that it can be
> > > > > > > > used, but the simplest is to create a patch normally using
> > > > > > > > git format-patch -s, obtaining eg 0001-changes.patch, and then run
> > > > > > > >
> > > > > > > > splitpatch 0001-changes.patch
> > > > > > > >
> > > > > > > > The output will include a 0001-changes.cover file, a set of
> > > > > > > > 0001-changesN.patch files with the various split patches, and a
> > > > > > > > 0001-changes.cmd file for sending it off with git send-email.
> > > > > > > >
> > > > > > > > This is available in the latest github version of Coccinelle.  Comments
> > > > > > > > are welcome.
> > > > > > >
> > > > > > > Thank you, Julia!  I will give it a try.
> > > > >
> > > > > Does the following error message mean that I need a more up-to-date
> > > > > version of ocaml or some such?
> > > > >
> > > > > 							Thanx, Paul
> > > > >
> > > > > File "globals/config.ml", line 1:
> > > > > Error: The implementation globals/config.ml
> > > > >        does not match the interface globals/config.cmi:
> > > > >        The field `python_interpreter' is required but not provided
> > > > >        The field `ocaml_version' is required but not provided
> > > > >        The field `configure_flags' is required but not provided
> > > > >        The field `get_temp_dir_name' is required but not provided
> > > > > make: *** [globals/config.cmo] Error 2
> > > >
> > > > I'm not familiar with that.  I assume you started with the github version
> > > > of Coccinelle.  Then ./autogen and ./configure.  Then make.  A recent
> > > > version of OCaml would indeed be good.  Maybe running make distclean
> > > > before ./autogen would be good.  The inconsistencies suggest that you have
> > > > some old compiled code hanging around.  The build infrastructure has
> > > > changed a lot recently, so it might not be managing code that predates the
> > > > changes in a way that you would expect.
> > >
> > > Good point, that does work much better.  Now -this- error message
> > > seems to be me having an old ocaml:
> > >
> > > ocamlfind ocamlopt -c  -no-alias-deps stdcompat__weak.mli -o stdcompat__weak.cmi
> > > ocamlopt: unknown option `-no-alias-deps'.
> > >
> > > Will get a new one and see how it goes...  ;-)
> > 
> > What version do you have?  I thought that the makefile would detect
> > unsupported versions, so perhaps that check needs to be improved.
> 
> I am running 4.0.3 and now installing 4.0.5.

But, sad to say, I get the same coccinelle build error on v4.0.5 ocaml.

Enlightenment?

							Thanx, Paul

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Cocci] sending out trewide patches
  2018-10-30 20:54               ` paulmck
@ 2018-10-30 21:11                 ` julia.lawall
  0 siblings, 0 replies; 10+ messages in thread
From: julia.lawall @ 2018-10-30 21:11 UTC (permalink / raw)
  To: cocci



On Tue, 30 Oct 2018, Paul E. McKenney wrote:

> On Tue, Oct 30, 2018 at 01:35:33PM -0700, Paul E. McKenney wrote:
> > On Tue, Oct 30, 2018 at 09:09:27PM +0100, Julia Lawall wrote:
> > >
> > >
> > > On Tue, 30 Oct 2018, Paul E. McKenney wrote:
> > >
> > > > On Tue, Oct 30, 2018 at 08:56:01PM +0100, Julia Lawall wrote:
> > > > >
> > > > >
> > > > > On Tue, 30 Oct 2018, Paul E. McKenney wrote:
> > > > >
> > > > > > On Sat, Oct 27, 2018 at 08:08:33PM +0200, Julia Lawall wrote:
> > > > > > >
> > > > > > >
> > > > > > > On Sat, 27 Oct 2018, Paul E. McKenney wrote:
> > > > > > >
> > > > > > > > On Sat, Oct 27, 2018 at 08:38:02AM +0200, Julia Lawall wrote:
> > > > > > > > > Hello,
> > > > > > > > >
> > > > > > > > > At OSS Europe, I got some questions about how to send out large
> > > > > > > > > Coccinelle-generated patches.  Coccinelle provides a tool tools/splitpatch
> > > > > > > > > (go to the tools subdirectory of the Coccinelle distribution and run make)
> > > > > > > > > that splits patches by set of maintainers (the default), by directory
> > > > > > > > > (--dirmerge option), or by file (--nomerge option).  There is a file
> > > > > > > > > tools/splitpatch.README that explains the various ways that it can be
> > > > > > > > > used, but the simplest is to create a patch normally using
> > > > > > > > > git format-patch -s, obtaining eg 0001-changes.patch, and then run
> > > > > > > > >
> > > > > > > > > splitpatch 0001-changes.patch
> > > > > > > > >
> > > > > > > > > The output will include a 0001-changes.cover file, a set of
> > > > > > > > > 0001-changesN.patch files with the various split patches, and a
> > > > > > > > > 0001-changes.cmd file for sending it off with git send-email.
> > > > > > > > >
> > > > > > > > > This is available in the latest github version of Coccinelle.  Comments
> > > > > > > > > are welcome.
> > > > > > > >
> > > > > > > > Thank you, Julia!  I will give it a try.
> > > > > >
> > > > > > Does the following error message mean that I need a more up-to-date
> > > > > > version of ocaml or some such?
> > > > > >
> > > > > > 							Thanx, Paul
> > > > > >
> > > > > > File "globals/config.ml", line 1:
> > > > > > Error: The implementation globals/config.ml
> > > > > >        does not match the interface globals/config.cmi:
> > > > > >        The field `python_interpreter' is required but not provided
> > > > > >        The field `ocaml_version' is required but not provided
> > > > > >        The field `configure_flags' is required but not provided
> > > > > >        The field `get_temp_dir_name' is required but not provided
> > > > > > make: *** [globals/config.cmo] Error 2
> > > > >
> > > > > I'm not familiar with that.  I assume you started with the github version
> > > > > of Coccinelle.  Then ./autogen and ./configure.  Then make.  A recent
> > > > > version of OCaml would indeed be good.  Maybe running make distclean
> > > > > before ./autogen would be good.  The inconsistencies suggest that you have
> > > > > some old compiled code hanging around.  The build infrastructure has
> > > > > changed a lot recently, so it might not be managing code that predates the
> > > > > changes in a way that you would expect.
> > > >
> > > > Good point, that does work much better.  Now -this- error message
> > > > seems to be me having an old ocaml:
> > > >
> > > > ocamlfind ocamlopt -c  -no-alias-deps stdcompat__weak.mli -o stdcompat__weak.cmi
> > > > ocamlopt: unknown option `-no-alias-deps'.
> > > >
> > > > Will get a new one and see how it goes...  ;-)
> > >
> > > What version do you have?  I thought that the makefile would detect
> > > unsupported versions, so perhaps that check needs to be improved.
> >
> > I am running 4.0.3 and now installing 4.0.5.
>
> But, sad to say, I get the same coccinelle build error on v4.0.5 ocaml.

I'm not so familiar with the OCaml version numbering system.  Mine is
4.06.0.  I don't see anything like 4.0.5 at https://ocaml.org/releases/

A buzilla entry suggests that this option has existed since OCaml 4.02.1.

julia

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, back to index

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-27  6:38 [Cocci] sending out trewide patches julia.lawall
2018-10-27 17:14 ` paulmck
2018-10-27 18:08   ` julia.lawall
2018-10-30 19:45     ` paulmck
2018-10-30 19:56       ` julia.lawall
2018-10-30 20:04         ` paulmck
2018-10-30 20:09           ` julia.lawall
2018-10-30 20:35             ` paulmck
2018-10-30 20:54               ` paulmck
2018-10-30 21:11                 ` julia.lawall

Coccinelle archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/cocci/0 cocci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 cocci cocci/ https://lore.kernel.org/cocci \
		cocci@systeme.lip6.fr cocci@archiver.kernel.org
	public-inbox-index cocci


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/fr.lip6.systeme.cocci


AGPL code for this site: git clone https://public-inbox.org/ public-inbox