cocci.inria.fr archive mirror
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Timur Tabi <timur@kernel.org>
Cc: cocci <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] Can the current function name be passed to a Python snippet?
Date: Wed, 5 Dec 2018 07:35:33 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.21.1812050734520.2670@hadrien> (raw)
In-Reply-To: <CAOZdJXUDY=D7mbCGTqyseq6nDsevAr9TFg9_utKnSQWPjH5a5g@mail.gmail.com>



On Tue, 4 Dec 2018, Timur Tabi wrote:

> On Tue, Dec 4, 2018 at 4:02 PM Timur Tabi <timur@kernel.org> wrote:
> > Based on what I've read, I need to add < > in order for spatch to run
> > the rule multiple times within a function.  But if I change r4 to
> > this:
> >
> > @r4 depends on rules@
> > identifier func;
> > expression x;
> > constant char[] c;
> > @@
> > func(...) {
> > <...
> > NV_PRINTF2(x, c, ...)
> > ...>
> > }
> >
> > It doesn't work at all.
>
> Ok, I changed it to
>
> func(...) {
> <+...
> NV_PRINTF2(x, c, ...)
> ...+>
> }
>
> and now it works.  I don't know why I needed the +'s, but at least it
> works now.  Thanks.

This means that the rule only applies when there is at least one
occurrence of the pattern in between the <+... ...+>.

The previous rule matched all functions.

julia
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  reply	other threads:[~2018-12-05  6:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15 20:58 [Cocci] Can the current function name be passed to a Python snippet? Timur Tabi
2018-11-15 21:29 ` Julia Lawall
2018-12-04 20:17   ` Timur Tabi
2018-12-04 20:25     ` Julia Lawall
2018-12-04 22:02       ` Timur Tabi
2018-12-04 22:19         ` Timur Tabi
2018-12-05  6:35           ` Julia Lawall [this message]
2018-12-05 17:49             ` Timur Tabi
2018-12-05 19:33               ` Julia Lawall
2018-12-05  6:34         ` Julia Lawall
2018-12-05 17:57           ` Timur Tabi
2018-12-05 18:32             ` Timur Tabi
2018-12-05 19:45               ` Julia Lawall
2018-12-05 19:11             ` Timur Tabi
2018-12-05 23:27               ` Timur Tabi
2018-12-06  6:33                 ` Julia Lawall
2018-12-05 19:32             ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1812050734520.2670@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=cocci@systeme.lip6.fr \
    --cc=timur@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).