Re: [Cocci] Can the current function name be passed to a Python snippet?

[Julia Lawall <julia.lawall@lip6.fr>]

On Wed, 5 Dec 2018, Timur Tabi wrote:

> On Wed, Dec 5, 2018 at 1:11 PM Timur Tabi <timur@kernel.org> wrote:
> >
> > Never mind, I now understand how the @p1 is supposed to be used.  I
> > have it working now.
>
> I spoke too soon, I'm getting a weird error:
>
> rule starting on line 232: already tagged token:
> C code context
> File "/tmp/cocci_small_output-22474-8398df.c", line 43, column 23,
> charpos = 1216
>   around = '"init_PllId: Error programming clock.  Stopping script.\n"',
>   whole content =                        "init_PllId: Error
> programming clock.  Stopping script.\n");
>
> Line 232 is the "depends on rule" in this snippet:
>
> // Get rid of the function name at the beginning of the string
> @script:python s4@
> c << r4.c;
> c2;
> p1 << r4.p1;
> @@
> import re
>
> f = p1[0].current_element
> coccinelle.c2 = re.sub('"%s[: ]*' % f, '"', c, 1)
>
> @depends on rules@
> expression x;
> constant char[] r4.c;
> identifier s4.c2;
> @@
> NV_PRINTF2(x,
> -c
> +c2
> ,...);

Probably the same string occurs in multiple functions, so you get multiple
new propositions for it.  To guard against this, you should reuse the
position variable:

@depends on rules@
expression x;
constant char[] r4.c;
position r4.p1;
identifier s4.c2;
@@
NV_PRINTF2(x,
-c@p1
+c2
,...);

You may need to move the @p1.  It should be in the same place that it
appears in r4.

julia
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci