From: Julia Lawall <julia.lawall@lip6.fr>
To: Jerome Glisse <jglisse@redhat.com>
Cc: cocci@systeme.lip6.fr
Subject: Re: [Cocci] Changing function pointer typedef
Date: Sun, 17 Mar 2019 19:43:45 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1903171943260.2434@hadrien> (raw)
In-Reply-To: <20190308193212.GE5618@redhat.com>
On Fri, 8 Mar 2019, Jerome Glisse wrote:
> On Fri, Mar 08, 2019 at 08:23:48PM +0100, Julia Lawall wrote:
> > > test.spatch
> > > @@
> > > type T1, T2;
> > > @@
> > > -typedef int (*filler_t)(T1,
> > > +typedef int (*filler_t)(T1, struct address_space *,
> >
> > If this is the whole rule, it is clear that it will not work. A semantic
> > patch rule has to e a complete syntactic unit. So something with an open
> > parenthesis and no corresponding close parenthesis will not be accepted.
>
> Yeah and adding "T2);" to the rule does not help either it error to
> error in collection of - tokens: line 4 less than line 6
>
> Any variation really do error in some way or another.
This problem is fixed. Thanks for the report.
julia
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
prev parent reply other threads:[~2019-03-17 18:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 18:19 [Cocci] Changing function pointer typedef Jerome Glisse
2019-03-08 18:57 ` Julia Lawall
2019-03-08 19:11 ` Jerome Glisse
2019-03-08 19:23 ` Julia Lawall
2019-03-08 19:32 ` Jerome Glisse
2019-03-17 18:43 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1903171943260.2434@hadrien \
--to=julia.lawall@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=jglisse@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).