cocci.inria.fr archive mirror
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: "Jérôme Glisse" <jglisse@redhat.com>
Cc: cocci@systeme.lip6.fr
Subject: Re: [Cocci] [PATCH] add __printf and __must_hold macro
Date: Mon, 8 Apr 2019 21:57:38 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1904082155480.2612@hadrien> (raw)
In-Reply-To: <20190408163534.29329-1-jglisse@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 820 bytes --]



On Mon, 8 Apr 2019, jglisse@redhat.com wrote:

> From: Jérôme Glisse <jglisse@redhat.com>
>
> Signed-off-by: Jérôme Glisse <jglisse@redhat.com>

Thanks for the contribution.  It's now available on github.

For macros, it would be helpful to do the following:

spatch --parse-c linuxkernel

apply patch

spatch --parse-c linuxkernel

Observe an improvement in the numbers that are printed out at the end.

These look safe enough, though.

julia

> ---
>  standard.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/standard.h b/standard.h
> index d9200643..7ce601be 100644
> --- a/standard.h
> +++ b/standard.h
> @@ -368,6 +368,9 @@
>  #define __releases(x)
>  #define __acquires(x)
>
> +#define __must_hold(x)
> +#define __printf(a,b)
> +
>  //now in lexer
>  //#define __declspec(x)
>
> --
> 2.20.1
>
>

[-- Attachment #2: Type: text/plain, Size: 136 bytes --]

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

      reply	other threads:[~2019-04-08 19:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-08 16:35 [Cocci] [PATCH] add __printf and __must_hold macro jglisse
2019-04-08 19:57 ` Julia Lawall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1904082155480.2612@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=cocci@systeme.lip6.fr \
    --cc=jglisse@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).