From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CBE5C31E46 for ; Wed, 12 Jun 2019 05:26:11 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 05E2F206E0 for ; Wed, 12 Jun 2019 05:26:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05E2F206E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lip6.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id x5C5Ptoa014540; Wed, 12 Jun 2019 07:25:55 +0200 (CEST) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id 86AF1776B; Wed, 12 Jun 2019 07:25:55 +0200 (CEST) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id 78EEE775F for ; Wed, 12 Jun 2019 07:25:53 +0200 (CEST) Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id x5C5PrWd000423 for ; Wed, 12 Jun 2019 07:25:53 +0200 (CEST) X-IronPort-AV: E=Sophos;i="5.63,363,1557180000"; d="scan'208";a="386976829" Received: from abo-12-105-68.mrs.modulonet.fr (HELO hadrien) ([85.68.105.12]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jun 2019 07:25:52 +0200 Date: Wed, 12 Jun 2019 07:25:52 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Timur Tabi In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Wed, 12 Jun 2019 07:25:56 +0200 (CEST) X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Wed, 12 Jun 2019 07:25:53 +0200 (CEST) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Cc: cocci Subject: Re: [Cocci] How to concatenate identifier with text? X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr On Tue, 11 Jun 2019, Timur Tabi wrote: > On Fri, May 24, 2019 at 2:38 PM Julia Lawall wrote: > > On Fri, 24 May 2019, Timur Tabi wrote: > > > I figured it out: > > > > > > @@ > > > identifier func; > > > fresh identifier label = func ## "_exit"; > > > > Yes, that works too. Simpler than my suggestion. > > I managed to break it somehow. I suspect I ran into some other quirk > of coccinelle. I'm trying to convert that looks like this: > > x = MACRO1(stuff); > if (x == NULL) > { > BREAKPOINT(); > status = ERROR; > goto myfunc_exit; > } > > into: > x = MACRO1(stuff); > CHECK_OR_BP_AND_GOTO(x == NULL, status, ERROR, _exit); > > I thought this would work: > > @@ > type T; > expression y, z; > identifier x, s; > identifier func; > fresh identifier label = func ## "_exit"; > @@ > func(...) { > <+... > x = > (T) > \(MACRO1\|MACRO2\) > (...); > -if (y) > -{ > - BREAKPOINT(); > - s = z; > - goto label; > -} > +CHECK_OR_BP_AND_GOTO(y, s, z, _exit); > ... > label: > ...+> > } > > but I get this error: > > 18: unexpected use of a fresh identifier label > > What am I missing? Fresh identifiers are only for + code. You need to construct the identifier you want to match using python code, as illustrated in demos/pythontococci.cocci julia _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci