From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E566CC43613 for ; Thu, 20 Jun 2019 18:48:41 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A04820656 for ; Thu, 20 Jun 2019 18:48:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A04820656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lip6.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id x5KImRZp007714; Thu, 20 Jun 2019 20:48:27 +0200 (CEST) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id ADD587781; Thu, 20 Jun 2019 20:48:27 +0200 (CEST) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id 0D8BA7778 for ; Thu, 20 Jun 2019 20:48:24 +0200 (CEST) Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id x5KImN8K011358 for ; Thu, 20 Jun 2019 20:48:23 +0200 (CEST) X-IronPort-AV: E=Sophos;i="5.63,397,1557180000"; d="scan'208";a="388394882" Received: from abo-12-105-68.mrs.modulonet.fr (HELO hadrien) ([85.68.105.12]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2019 20:48:23 +0200 Date: Thu, 20 Jun 2019 20:48:23 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Markus Elfring In-Reply-To: <05d85182-7ec3-8fc1-4bcd-fd2528de3a40@web.de> Message-ID: References: <05d85182-7ec3-8fc1-4bcd-fd2528de3a40@web.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1240475580-1561056503=:3087" X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Thu, 20 Jun 2019 20:48:28 +0200 (CEST) X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Thu, 20 Jun 2019 20:48:23 +0200 (CEST) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Cc: Michal Marek , kernel-janitors@vger.kernel.org, Nicolas Palix , LKML , Ding Xiang , Coccinelle Subject: Re: [Cocci] [PATCH] Coccinelle: Add a SmPL script for the reconsideration of redundant dev_err() calls X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1240475580-1561056503=:3087 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT On Thu, 20 Jun 2019, Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 20 Jun 2019 19:12:53 +0200 > > The function “devm_ioremap_resource” contains appropriate error reporting. > Thus it can be questionable to present another error message > at other places. > > Provide design options for the adjustment of affected source code > by the means of the semantic patch language (Coccinelle software). > > Signed-off-by: Markus Elfring > --- > .../coccinelle/misc/redundant_dev_err.cocci | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 scripts/coccinelle/misc/redundant_dev_err.cocci > > diff --git a/scripts/coccinelle/misc/redundant_dev_err.cocci b/scripts/coccinelle/misc/redundant_dev_err.cocci > new file mode 100644 > index 000000000000..aeb228280276 > --- /dev/null > +++ b/scripts/coccinelle/misc/redundant_dev_err.cocci > @@ -0,0 +1,53 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/// Reconsider a function call for redundant error reporting. > +// > +// Keywords: dev_err redundant device error messages > +// Confidence: Medium > + > +virtual patch > +virtual context > +virtual org > +virtual report > + > +@display depends on context@ > +expression e; > +@@ > + e = devm_ioremap_resource(...); > + if (IS_ERR(e)) > + { > +* dev_err(...); > + return (...); > + } Why do you assume that there is exactly one dev_err and one return after the test? > + > +@deletion depends on patch@ > +expression e; > +@@ > + e = devm_ioremap_resource(...); > + if (IS_ERR(e)) > +-{ > +- dev_err(...); > + return (...); > +-} > + > +@or depends on org || report@ > +expression e; > +position p; > +@@ > + e = devm_ioremap_resource(...); > + if (IS_ERR(e)) > + { > + dev_err@p(...); > + return (...); > + } > + > +@script:python to_do depends on org@ > +p << or.p; > +@@ > +coccilib.org.print_todo(p[0], > + "WARNING: An error message is probably not needed here because the previously called function contains appropriate error reporting.") "the previously called function" would be better as "devm_ioremap_resource". julia > + > +@script:python reporting depends on report@ > +p << or.p; > +@@ > +coccilib.report.print_report(p[0], > + "WARNING: An error message is probably not needed here because the previously called function contains appropriate error reporting.") > -- > 2.22.0 > > --8323329-1240475580-1561056503=:3087 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci --8323329-1240475580-1561056503=:3087--