From: Julia Lawall <julia.lawall@lip6.fr>
To: Kirill Smelkov <kirr@nexedi.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-kernel@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>,
Logan Gunthorpe <logang@deltatee.com>,
cocci@systeme.lip6.fr
Subject: Re: [Cocci] [PATCH 1/2] coccinelle: api/stream_open: treat all wait_.*() calls as blocking
Date: Sun, 23 Jun 2019 09:35:17 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1906230934080.4961@hadrien> (raw)
In-Reply-To: <20190623072838.31234-1-kirr@nexedi.com>
On Sun, 23 Jun 2019, Kirill Smelkov wrote:
> Previously steam_open.cocci was treating only wait_event_.* - e.g.
> wait_event_interruptible - as a blocking operation. However e.g.
> wait_for_completion_interruptible is also blocking, and so from this
> point of view it would be more logical to treat all wait_.* as a
> blocking point.
>
> The logic of this change actually came up for real when
> drivers/pci/switch/switchtec.c changed from using
> wait_event_interruptible to wait_for_completion_interruptible:
>
> https://lore.kernel.org/linux-pci/20190413170056.GA11293@deco.navytux.spb.ru/
> https://lore.kernel.org/linux-pci/20190415145456.GA15280@deco.navytux.spb.ru/
> https://lore.kernel.org/linux-pci/20190415154102.GB17661@deco.navytux.spb.ru/
>
> For a driver that uses nonseekable_open with read/write having stream
> semantic and read also calling e.g. wait_for_completion_interruptible,
> running stream_open.cocci before this patch would produce:
>
> WARNING: <driver>_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open.
>
> while after this patch it will report:
>
> ERROR: <driver>_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
Are you really sure that every word that starts with wait_ in the Linux
kernel has the property you want? How many of them are there? Would it
be reasonable to put the names in the semantic patch explicitly?
julia
>
> Cc: Julia Lawall <Julia.Lawall@lip6.fr>
> Cc: Logan Gunthorpe <logang@deltatee.com>
> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Cc: Bjorn Helgaas <helgaas@kernel.org>
> Signed-off-by: Kirill Smelkov <kirr@nexedi.com>
> ---
> scripts/coccinelle/api/stream_open.cocci | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/coccinelle/api/stream_open.cocci b/scripts/coccinelle/api/stream_open.cocci
> index 350145da7669..12ce18fa6b74 100644
> --- a/scripts/coccinelle/api/stream_open.cocci
> +++ b/scripts/coccinelle/api/stream_open.cocci
> @@ -35,11 +35,11 @@ type loff_t;
> // a function that blocks
> @ blocks @
> identifier block_f;
> -identifier wait_event =~ "^wait_event_.*";
> +identifier wait =~ "^wait_.*";
> @@
> block_f(...) {
> ... when exists
> - wait_event(...)
> + wait(...)
> ... when exists
> }
>
> @@ -49,12 +49,12 @@ identifier wait_event =~ "^wait_event_.*";
> // XXX currently reader_blocks supports only direct and 1-level indirect cases.
> @ reader_blocks_direct @
> identifier stream_reader.readstream;
> -identifier wait_event =~ "^wait_event_.*";
> +identifier wait =~ "^wait_.*";
> @@
> readstream(...)
> {
> ... when exists
> - wait_event(...)
> + wait(...)
> ... when exists
> }
>
> --
> 2.20.1
>
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2019-06-23 7:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-23 7:28 [Cocci] [PATCH 1/2] coccinelle: api/stream_open: treat all wait_.*() calls as blocking Kirill Smelkov
2019-06-23 7:29 ` [Cocci] [PATCH 2/2] *: convert stream-like files -> stream_open, even if they use noop_llseek Kirill Smelkov
2019-06-23 7:35 ` Julia Lawall [this message]
2019-06-23 8:01 ` [Cocci] [PATCH 1/2] coccinelle: api/stream_open: treat all wait_.*() calls as blocking Julia Lawall
[not found] ` <alpine.DEB.2.21.1906231002020.4961@hadrien>
2019-06-23 8:18 ` Kirill Smelkov
2019-07-06 13:17 ` Masahiro Yamada
2019-07-07 18:20 ` Kirill Smelkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1906230934080.4961@hadrien \
--to=julia.lawall@lip6.fr \
--cc=bigeasy@linutronix.de \
--cc=cocci@systeme.lip6.fr \
--cc=helgaas@kernel.org \
--cc=kirr@nexedi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=logang@deltatee.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).