From: Julia Lawall <julia.lawall@lip6.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Rob Herring <robh@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
YueHaibing <yuehaibing@huawei.com>,
Nicolas Palix <nicolas.palix@imag.fr>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephen Boyd <swboyd@chromium.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Mark Brown <broonie@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Javier Martinez Canillas <javierm@redhat.com>,
cocci@systeme.lip6.fr, Russell King <linux@armlinux.org.uk>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [Cocci] [PATCH -next] coccinelle: platform_get_irq: Fix parse error
Date: Fri, 6 Sep 2019 08:59:02 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1909060857290.2975@hadrien> (raw)
In-Reply-To: <7818ad20-615c-2ce9-c0d1-3f7a09bedf34@web.de>
On Fri, 6 Sep 2019, Markus Elfring wrote:
> > > minus: parse error:
> > > File "./scripts/coccinelle/api/platform_get_irq.cocci", line 24, column 9, charpos = 355
> > > around = '\(',
> > > whole content = if ( ret \( < \| <= \) 0 )
> > >
> > > In commit e56476897448 ("fpga: Remove dev_err() usage
> > > after platform_get_irq()") log, I found the semantic patch,
> > > it fix this issue.
> > >
> > > Fixes: 98051ba2b28b ("coccinelle: Add script to check for platform_get_irq() excessive prints")
> > > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > > ---
> >
> > Hmm I had this earlier but someone asked me to change it.
>
> I proposed something also during the development for this SmPL script.
> https://lkml.org/lkml/2019/7/24/274
> https://lore.kernel.org/r/c98b8f50-1adf-ea95-a91c-ec451e9fefe2@web.de/
Markus,
This is not the first time you have suggested to someone to do something
that was simply incorrect. Please actually test your suggestions before
proposing them.
> > Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>
> Should disjunctions eventually work in the semantic patch language also together with
> comparison operators?
> https://github.com/coccinelle/coccinelle/issues/40
No.
> Will any additional software adjustments be taken into account?
No.
julia
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
prev parent reply other threads:[~2019-09-06 7:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 3:30 [Cocci] [PATCH -next] coccinelle: platform_get_irq: Fix parse error YueHaibing
2019-09-06 5:09 ` Julia Lawall
2019-09-06 5:15 ` Stephen Boyd
2019-09-06 6:52 ` Markus Elfring
2019-09-06 6:59 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1909060857290.2975@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Markus.Elfring@web.de \
--cc=a.hajda@samsung.com \
--cc=andy.shevchenko@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=cocci@systeme.lip6.fr \
--cc=gregkh@linuxfoundation.org \
--cc=javierm@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=robh@kernel.org \
--cc=swboyd@chromium.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).