Coccinelle archive on lore.kernel.org
 help / color / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>
Cc: Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] const in parameter lists
Date: Thu, 12 Sep 2019 13:31:52 +0200 (CEST)
Message-ID: <alpine.DEB.2.21.1909121330300.2876@hadrien> (raw)
In-Reply-To: <20190912111304.2fu3lcqmtgbnolpx@gintonic.linbit>

[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]



On Thu, 12 Sep 2019, Christoph Böhmwalder wrote:

> Hi,
>
> I'm having trouble removing const arguments from a function. I think this issue
> is best explained in code:
>
> $ cat repro.c
> f(int x,
>   const unsigned a,
>   const char *y)
> {
> }
>
> $ cat repro.cocci
> @@
> identifier a;
> @@
> f(...
> - , unsigned a
> + , unsigned b
> ,...)
> {
> ...
> }
>
> $ spatch --sp-file repro.cocci --very-quiet repro.c
> --- repro.c
> +++ /tmp/cocci-output-17454-200d33-repro.c
> @@ -1,5 +1,5 @@
> -f(int x,
> -  const unsigned a,
> +f(int x
> +  const, unsigned b,
>    const char *y)
>  {
>  }
>
>
> When I try to remove some parameter(s) in the middle (in my real use case
> I'm trying to remove 2) the 'const' ends up in weird places.
>
> Obviously I've tried (with and without disable optional_qualifier):
>
>     f(...
>     - , const unsigned a
>     + , const unsigned b
>     ,...)
>
> but that gives:
>
>     minus: parse error:
>       File "repro.cocci", line 5, column 19, charpos = 45
>       around = 'a',
>       whole content = - , const unsigned a
>
> How can I tell coccinelle that I want a const here?


Sorry, it's not clear to me what you want to do.  Do you want to verify
that there is a const before renaming the parameter?  Could you do

const unsigned
-a
+b

?

julia

>
> Thanks,
> --
> Christoph Böhmwalder
> LINBIT | Keeping the Digital World Running
> DRBD HA —  Disaster Recovery — Software defined Storage
> _______________________________________________
> Cocci mailing list
> Cocci@systeme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci
>

[-- Attachment #2: Type: text/plain, Size: 136 bytes --]

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-12 11:13 Christoph Böhmwalder
2019-09-12 11:31 ` Julia Lawall [this message]
2019-09-12 12:34   ` Christoph Böhmwalder
2019-09-12 12:50     ` Julia Lawall
2019-09-12 14:33     ` Markus Elfring
2019-09-12 14:49       ` Julia Lawall
2019-09-12 14:56         ` Markus Elfring
2019-09-14 20:00     ` Julia Lawall
2019-09-15 11:38       ` Markus Elfring

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1909121330300.2876@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=christoph.boehmwalder@linbit.com \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Coccinelle archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/cocci/0 cocci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 cocci cocci/ https://lore.kernel.org/cocci \
		cocci@systeme.lip6.fr cocci@archiver.kernel.org
	public-inbox-index cocci


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/fr.lip6.systeme.cocci


AGPL code for this site: git clone https://public-inbox.org/ public-inbox