From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15FD0C47404 for ; Thu, 12 Sep 2019 12:50:21 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BCAB20830 for ; Thu, 12 Sep 2019 12:50:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BCAB20830 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lip6.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id x8CCo5Ku022119; Thu, 12 Sep 2019 14:50:05 +0200 (CEST) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id 5C9DF7798; Thu, 12 Sep 2019 14:50:05 +0200 (CEST) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id A2CC07797 for ; Thu, 12 Sep 2019 14:50:03 +0200 (CEST) Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id x8CCo3oG013358 for ; Thu, 12 Sep 2019 14:50:03 +0200 (CEST) X-IronPort-AV: E=Sophos;i="5.64,497,1559512800"; d="scan'208";a="401431823" Received: from portablejulia.rsr.lip6.fr ([132.227.76.63]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Sep 2019 14:50:03 +0200 Date: Thu, 12 Sep 2019 14:50:04 +0200 (CEST) From: Julia Lawall X-X-Sender: julia@hadrien To: =?ISO-8859-15?Q?Christoph_B=F6hmwalder?= In-Reply-To: <20190912123435.ztwsymd7m4s4n6hq@gintonic.linbit> Message-ID: References: <20190912111304.2fu3lcqmtgbnolpx@gintonic.linbit> <20190912123435.ztwsymd7m4s4n6hq@gintonic.linbit> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1980229386-1568292511=:2876" Content-ID: X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Thu, 12 Sep 2019 14:50:05 +0200 (CEST) X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Thu, 12 Sep 2019 14:50:03 +0200 (CEST) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Cc: Coccinelle Subject: Re: [Cocci] const in parameter lists X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1980229386-1568292511=:2876 Content-Type: text/plain; CHARSET=ISO-8859-15 Content-Transfer-Encoding: 8BIT Content-ID: On Thu, 12 Sep 2019, Christoph Böhmwalder wrote: > On Thu, Sep 12, 2019 at 01:31:52PM +0200, Julia Lawall wrote: > > > > Sorry, it's not clear to me what you want to do. Do you want to verify > > that there is a const before renaming the parameter? Could you do > > > > const unsigned > > -a > > +b > > > > ? > > > > julia > > I'll try and outline what I'm actually trying to do. > > Here's what I have: > > int drbd_submit_peer_request(struct drbd_device *device, > struct drbd_peer_request *peer_req, > const unsigned op, const unsigned op_flags, > const int fault_type) > { > // ... > } > > This is what I want: > > int drbd_submit_peer_request(struct drbd_device *device, > struct drbd_peer_request *peer_req, > const unsigned rw, > const int fault_type) > { > // ... > } > > And this is my cocci patch: > > @@ > identifier op, op_flags; > struct bio *b; > @@ > drbd_submit_peer_request(... > - , const unsigned op, const unsigned op_flags > + , const unsigned rw > ,...) > { > ... > } > > This gives an error: > > minus: parse error: > File "drbd/drbd-kernel-compat/cocci/req_write__yes_present.cocci", line 35, column 22, charpos = 548 > around = 'op', > whole content = - , const unsigned op, const unsigned op_flags > > > Doing it without the consts yields this: > > int drbd_submit_peer_request(struct drbd_device *device, > - struct drbd_peer_request *peer_req, > - const unsigned op, const unsigned op_flags, > + struct drbd_peer_request *peer_reqconst, > + unsigned rw, > const int fault_type) > { > > Notice the stray "const" behind "peer_req". > > So -- to answer your question -- my priority here is to get the code > compiling; I don't actually care about any of the consts. Best case > scenario would be to have it remove whether or not the consts are there > and always add the new parameter with a const. How about the following? @@ identifier op, op_flags; struct bio *b; type T; @@ T drbd_submit_peer_request(..., - unsigned op + unsigned rw , - unsigned op_flags, ...) { ... } It doesn't add a const on rw, though. And it doesn't allow using the const to figure out where to match. I will have to look into why the consts aren't being parsed properly. julia --8323329-1980229386-1568292511=:2876 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci --8323329-1980229386-1568292511=:2876--