cocci.inria.fr archive mirror
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: YueHaibing <yuehaibing@huawei.com>
Cc: michal.lkml@markovi.net, nicolas.palix@imag.fr,
	maennich@google.com, linux-kernel@vger.kernel.org,
	gregkh@linuxfoundation.org, cocci@systeme.lip6.fr
Subject: Re: [Cocci] [RFC PATCH] scripts: Fix coccicheck failed
Date: Sat, 28 Sep 2019 05:43:57 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.21.1909280542490.2168@hadrien> (raw)
In-Reply-To: <20190928094245.45696-1-yuehaibing@huawei.com>



On Sat, 28 Sep 2019, YueHaibing wrote:

> Run make coccicheck, I got this:
>
> spatch -D patch --no-show-diff --very-quiet --cocci-file
>  ./scripts/coccinelle/misc/add_namespace.cocci --dir .
>  -I ./arch/x86/include -I ./arch/x86/include/generated
>  -I ./include -I ./arch/x86/include/uapi
>  -I ./arch/x86/include/generated/uapi -I ./include/uapi
>  -I ./include/generated/uapi --include ./include/linux/kconfig.h
>  --jobs 192 --chunksize 1
>
> virtual rule patch not supported
> coccicheck failed
>
> It seems add_namespace.cocci cannot be called in coccicheck.

Could you explain the issue better?  Does the current state cause make
coccicheck to fail?  Or is it just silently not being called?

thanks,
julia

>
> Fixes: eb8305aecb95 ("scripts: Coccinelle script for namespace dependencies.")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  scripts/{coccinelle/misc => }/add_namespace.cocci | 0
>  scripts/nsdeps                                    | 2 +-
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename scripts/{coccinelle/misc => }/add_namespace.cocci (100%)
>
> diff --git a/scripts/coccinelle/misc/add_namespace.cocci b/scripts/add_namespace.cocci
> similarity index 100%
> rename from scripts/coccinelle/misc/add_namespace.cocci
> rename to scripts/add_namespace.cocci
> diff --git a/scripts/nsdeps b/scripts/nsdeps
> index ac2b6031dd13..0f743b76e501 100644
> --- a/scripts/nsdeps
> +++ b/scripts/nsdeps
> @@ -23,7 +23,7 @@ fi
>
>  generate_deps_for_ns() {
>  	$SPATCH --very-quiet --in-place --sp-file \
> -		$srctree/scripts/coccinelle/misc/add_namespace.cocci -D ns=$1 $2
> +		$srctree/scripts/add_namespace.cocci -D ns=$1 $2
>  }
>
>  generate_deps() {
> --
> 2.20.1
>
>
>
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  reply	other threads:[~2019-09-28 12:44 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-28  9:42 [Cocci] [RFC PATCH] scripts: Fix coccicheck failed YueHaibing
2019-09-28 12:43 ` Julia Lawall [this message]
2019-09-29  2:04   ` Yuehaibing
2019-09-29 16:32     ` Julia Lawall
2019-09-29 18:00       ` Markus Elfring
2019-09-29 18:05         ` Julia Lawall
2019-09-29 18:18           ` [Cocci] [RFC] " Markus Elfring
2019-09-30  2:32       ` [Cocci] [RFC PATCH] " Yuehaibing
2019-10-01 12:57         ` Matthias Maennich
2019-10-01 15:33           ` [Cocci] [RFC] " Markus Elfring
2019-10-01 13:01         ` [Cocci] [RFC PATCH] " Julia Lawall
2019-10-03 11:57           ` Masahiro Yamada
2019-10-03 12:22             ` Julia Lawall
2019-10-04  2:32               ` Masahiro Yamada
2019-10-05 11:17                 ` [Cocci] [RFC] " Markus Elfring
2019-10-05 12:26                   ` Julia Lawall
2019-10-05 17:49                     ` Markus Elfring
2019-10-05 17:49                     ` Markus Elfring
2019-10-06  5:21                     ` Markus Elfring
2019-10-06  5:28                       ` Julia Lawall
2019-10-06  5:34                         ` Markus Elfring
2019-10-06  7:30                           ` Greg Kroah-Hartman
2019-10-06  4:23                 ` [Cocci] [RFC PATCH] " Yuehaibing
2019-10-06  4:44                 ` [Cocci] [PATCH] scripts: add_namespace: " YueHaibing
2019-10-06  6:40                   ` Markus Elfring
2019-10-06  6:44                     ` Julia Lawall
2019-10-06  7:00                       ` [Cocci] " Markus Elfring
2019-10-06 11:09                   ` [Cocci] [PATCH] " Matthias Maennich
2019-10-07 13:15                   ` Jessica Yu
2019-10-03 16:30             ` [Cocci] [RFC] scripts: " Markus Elfring
2019-10-03 16:30             ` Markus Elfring
2019-10-03 19:35               ` Julia Lawall
2019-10-04  8:23                 ` Markus Elfring
2019-09-29  8:20 ` [Cocci] [RFC PATCH] " Markus Elfring
2019-09-29 13:12 ` Markus Elfring
2019-09-29 16:40   ` Julia Lawall
2019-10-02  7:09     ` [Cocci] [PATCH 0/2] Coccinelle: Extend directory hierarchy Markus Elfring
2019-10-02  7:10       ` [Cocci] [PATCH 1/2] Coccinelle: Move the SmPL script “add_namespace.cocci” into a new directory Markus Elfring
2019-10-02  7:12       ` [Cocci] [PATCH 2/2] Coccinelle: Move coccicheck directories into a new subdirectory Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1909280542490.2168@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=cocci@systeme.lip6.fr \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maennich@google.com \
    --cc=michal.lkml@markovi.net \
    --cc=nicolas.palix@imag.fr \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).