From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBF36C47404 for ; Fri, 11 Oct 2019 06:08:18 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E3E42196E for ; Fri, 11 Oct 2019 06:08:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E3E42196E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lip6.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id x9B67x7s001516; Fri, 11 Oct 2019 08:07:59 +0200 (CEST) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id 6533877B1; Fri, 11 Oct 2019 08:07:59 +0200 (CEST) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id A7C8A77AE for ; Fri, 11 Oct 2019 08:07:57 +0200 (CEST) Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id x9B67vjT023048 for ; Fri, 11 Oct 2019 08:07:57 +0200 (CEST) X-IronPort-AV: E=Sophos;i="5.67,283,1566856800"; d="scan'208";a="405697086" Received: from 81-65-53-202.rev.numericable.fr (HELO hadrien) ([81.65.53.202]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Oct 2019 08:07:57 +0200 Date: Fri, 11 Oct 2019 08:07:57 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Markus Elfring In-Reply-To: Message-ID: References: <24130ec6-4a20-7be4-755f-a6dfffcb6c97@web.de> <8df6513d-36d3-2049-8fb0-28d84c8f9c85@web.de> <293c83c3-d7b9-8c55-59e0-eaf7fd2fcc84@web.de> <678d756b-a8ac-12c0-cdbe-96b49fc4eb2c@web.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-426416210-1570774077=:2662" X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Fri, 11 Oct 2019 08:07:59 +0200 (CEST) X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Fri, 11 Oct 2019 08:07:57 +0200 (CEST) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Cc: Coccinelle Subject: Re: [Cocci] Software analysis with SmPL around unchecked function calls X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-426416210-1570774077=:2662 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT On Fri, 11 Oct 2019, Markus Elfring wrote: > > And what is the questionable source code place? > > I find implementation details occasionally questionable where checks for variables > which provide a stored function return value are missing. > The possibility remains that also your search pattern suggestion will point > update candidates out at other places than the implementation of the mentioned > function “imx_pd_bind”. Blah, blah, blah. So many words. So little information. What is the name of the file and the line number at which you get a result that you find inacceptable with my rule? If you can't answer that simple question, I'm not going to discuss this further. julia > > How do you think about the following SmPL script variant? > > @display@ > expression x, y; > identifier f, md; > @@ > *(x)->md = kmemdup(...); > ... when != (x)->md > (((x)->md)->f > |f(..., <+... x ...+>, ...) > |(y = x) > ) > > > Regards, > Markus > --8323329-426416210-1570774077=:2662 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci --8323329-426416210-1570774077=:2662--