cocci.inria.fr archive mirror
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: "Jürgen Groß" <jgross@suse.com>, Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] macro parameters and expressions?
Date: Tue, 15 Oct 2019 10:05:26 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1910151004110.3774@hadrien> (raw)
In-Reply-To: <aa8de6c2-7baf-321a-2447-29f6b107eb9c@web.de>

[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]



On Tue, 15 Oct 2019, Markus Elfring wrote:

> >> * Fix search for parameterised macros with SmPL
> >>   https://github.com/coccinelle/coccinelle/issues/94
> …
> > There are no #defines in his semantic patch.
>
> This design detail can probably be taken also better into account
> if other software development challenges will finally be solved.
>
> elfring@Sonne:~/Projekte/Coccinelle/Probe> spatch --parse-c Jürgen_Groß-Beispiel1.c
> …
> (ONCE) LEXER:unrecognised symbol, in token rule:\
> LEXER: WIERD end of file in string
> PB: not found closing paren in fuzzy parsing
> …
> BAD:!!!!! #define MACRO(name)    snprintf(pg, PAGE_SIZE, %u\n", ptr->name)

If a " is missing then the code can't be parsed and Coccinelle won't do
anything.  But I don't know if this was a bug in the original code or
something you have modified; you sent another message that did not have
this problem.

> https://wiki.sei.cmu.edu/confluence/display/c/PRE11-C.+Do+not+conclude+macro+definitions+with+a+semicolon
> https://gcc.gnu.org/onlinedocs/cpp/Swallowing-the-Semicolon.html
>
> How will the software situation be improved further?

What software situation?

julia

[-- Attachment #2: Type: text/plain, Size: 136 bytes --]

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  parent reply	other threads:[~2019-10-15  8:05 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-11  7:42 [Cocci] macro parameters and expressions? Jürgen Groß
2019-10-11 20:00 ` Julia Lawall
2019-10-13 13:37   ` Markus Elfring
     [not found]     ` <alpine.DEB.2.21.1910131806400.2565@hadrien>
2019-10-13 16:33       ` [Cocci] Adjusting macros with SmPL? Markus Elfring
2019-10-13 16:37         ` Julia Lawall
2019-10-13 16:50           ` Markus Elfring
2019-10-14  9:08           ` Markus Elfring
2019-10-14 10:24             ` Julia Lawall
2019-10-14 11:00               ` Markus Elfring
2019-10-15  8:20               ` Markus Elfring
2019-10-16 14:16               ` [Cocci] Adjustments with SmPL after macros? Markus Elfring
2019-10-16 15:23                 ` Julia Lawall
2019-10-16 16:48                   ` Markus Elfring
     [not found]                     ` <alpine.DEB.2.21.1910161850250.3539@hadrien>
2019-10-16 16:55                       ` Markus Elfring
2019-10-17  9:33                   ` Markus Elfring
     [not found]   ` <fb924870-4bc2-1ca0-4fa4-0ddbf7ebb9d2@suse.com>
2019-10-14 11:14     ` [Cocci] macro parameters and expressions? Julia Lawall
2019-10-14 11:50       ` Markus Elfring
2019-10-14 13:33       ` Jürgen Groß
2019-10-14 14:03         ` Julia Lawall
2019-10-13 13:28 ` Markus Elfring
2019-10-13 13:36   ` Julia Lawall
2019-10-13 14:22     ` [Cocci] Checking the influence of “virtual” SmPL variables Markus Elfring
2019-10-13 16:09       ` Julia Lawall
2019-10-13 16:39         ` Markus Elfring
2019-10-14 15:33 ` [Cocci] macro parameters and expressions? Markus Elfring
     [not found]   ` <alpine.DEB.2.21.1910141740580.2330@hadrien>
2019-10-14 16:05     ` Markus Elfring
2019-10-15  6:44     ` Markus Elfring
2019-10-15  6:54       ` Markus Elfring
2019-10-15  7:40       ` Markus Elfring
2019-10-15  8:05       ` Julia Lawall [this message]
2019-10-15  8:34         ` Markus Elfring
2019-10-15  9:07         ` Markus Elfring
2019-10-15  9:28           ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1910151004110.3774@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=Markus.Elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    --cc=jgross@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).