Coccinelle archive on
 help / color / Atom feed
From: Julia Lawall <>
To: "Ondřej Surý" <>
Subject: Re: [Cocci] Detecting functions with dummy return value
Date: Sat, 2 Nov 2019 07:40:42 +0100 (CET)
Message-ID: <alpine.DEB.2.21.1911020739360.3254@hadrien> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 1383 bytes --]

On Fri, 1 Nov 2019, Ondřej Surý wrote:

> Hi Julia,
> thanks for the quick response.
> > On 1 Nov 2019, at 14:09, Julia Lawall <> wrote:
> >
> > This is not possible.  ... describes control-flow paths.  Nothing happens
> > after a return.  Your attempt above would match functions where all
> > control-flow paths end with return (ISC_R_SUCCESS);, even if some of those
> > returns are in if branches.
> I think that would be still fine, I mostly want the Coccinelle to select the functions
> that need my attention and we also use Coccinelle in our CI pipelines, so we don’t
> reintroduce the code we already cleaned up.
> So, if I could just mark the functions that *only* return ISC_R_SUCCESS anywhere,
> it would be enough for my use case.  I would then go through the results by hand
> and write a targeted spatch for every selected function.  That’s fine, even though
> Coccinelle feels like a magic wand, I don’t expect it to be one.
> The spatch you sent ends up with:
> minus: parse error:
>   File "cocci/dummy.spatch", line 7, column 0, charpos = 50
>   around = 'foo',
>   whole content = foo(...) {

Sorry, you also need:

typedef isc_result_t;

in the metavariable list.

> BTW Coccinelle is such a great tool, it has helped with BIND 9
> refactoring so much, so thank you for working on that!

Nice to hear :) Thanks.


[-- Attachment #2: Type: text/plain, Size: 136 bytes --]

Cocci mailing list

      reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-01 14:52 Ondřej Surý
2019-11-01 19:09 ` Julia Lawall
2019-11-01 19:22   ` Ondřej Surý
2019-11-02  6:40     ` Julia Lawall [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1911020739360.3254@hadrien \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Coccinelle archive on

Archives are clonable:
	git clone --mirror cocci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 cocci cocci/ \
	public-inbox-index cocci

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone