From: Julia Lawall <julia.lawall@inria.fr>
To: Jaskaran Singh <jaskaransingh7654321@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org, cocci@systeme.lip6.fr
Subject: Re: [Cocci] [PATCH v3 0/3] cocci: Improve management of macros before typedefs
Date: Sat, 25 Jan 2020 16:01:28 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.2001251601130.3236@hadrien> (raw)
In-Reply-To: <20200121122458.5513-1-jaskaransingh7654321@gmail.com>
On Tue, 21 Jan 2020, Jaskaran Singh wrote:
> This patch series is for improving the management of the following
> case:
>
> <macro> <typedef> <ident>
>
> If <typedef> is a known typedef (such as u8 or *_t) then label <macro> as a
> CppMacro. Subsequent cases will continue to label <typedef> correctly as a
> typedef identifier.
>
> Also add bool to the list of known typedefs so that cases of
>
> <macro> bool <ident>
>
> are handled correctly just like any known typedef will be.
>
> Changes in v3:
> --------------
> - Change "subsequent cases will label" to "subsequent cases will continue to
> label" in commit messages of Patch 0/3 and Patch 1/3.
> - Change the term "typedef ident" to "typedef identifier" wherever
> suitable.
> - Add metavariable symbol false to tests/macro_before_bool.cocci to
> suppress warning.
>
> Changes in v2:
> --------------
> - Group these patches as a series for clarity
> - Add a test case for <macro> bool <ident> (Patch 3/3)
> - Explain what has been improved with Patch 2/3
All applied. Thanks!
julia
>
> parsing_c/parsing_hacks.ml | 37 ++++++++++++++++++++++++++++++++++++-
> tests/macro_before_bool.c | 4 ++++
> tests/macro_before_bool.cocci | 10 ++++++++++
> tests/macro_before_bool.res | 5 +++++
> 4 files changed, 55 insertions(+), 1 deletion(-)
>
>
>
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2020-01-25 15:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 8:04 [Cocci] [PATCH v2 0/3] cocci: Improve management of macros before typedefs Jaskaran Singh
2020-01-21 8:04 ` [Cocci] [PATCH v2 1/3] parsing_c: Handle case of macro before typedef Jaskaran Singh
2020-01-21 8:04 ` [Cocci] [PATCH v2 2/3] parsing_hacks: Add bool to list of known typedefs Jaskaran Singh
2020-01-21 8:04 ` [Cocci] [PATCH v2 3/3] tests: Add test case for <macro> bool <ident> Jaskaran Singh
2020-01-21 12:24 ` [Cocci] [PATCH v3 0/3] cocci: Improve management of macros before typedefs Jaskaran Singh
2020-01-25 15:01 ` Julia Lawall [this message]
2020-01-21 12:27 ` [Cocci] [PATCH v3 1/3] parsing_c: Handle case of macro before typedef Jaskaran Singh
2020-01-21 12:27 ` [Cocci] [PATCH v3 2/3] parsing_hacks: Add bool to list of known typedefs Jaskaran Singh
2020-01-21 12:27 ` [Cocci] [PATCH v3 3/3] tests: Add test case for <macro> bool <ident> Jaskaran Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2001251601130.3236@hadrien \
--to=julia.lawall@inria.fr \
--cc=cocci@systeme.lip6.fr \
--cc=jaskaransingh7654321@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).