From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33B09C2D0E5 for ; Fri, 27 Mar 2020 16:15:55 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA19420658 for ; Fri, 27 Mar 2020 16:15:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA19420658 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=inria.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id 02RGFet3012818; Fri, 27 Mar 2020 17:15:40 +0100 (CET) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id 670257812; Fri, 27 Mar 2020 17:15:40 +0100 (CET) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id 062F8780C for ; Fri, 27 Mar 2020 17:15:38 +0100 (CET) Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTPS id 02RGFaGi011213 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 27 Mar 2020 17:15:36 +0100 (CET) X-IronPort-AV: E=Sophos;i="5.72,313,1580770800"; d="scan'208";a="442666116" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2020 17:15:36 +0100 Date: Fri, 27 Mar 2020 17:15:36 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: =?ISO-8859-15?Q?Christoph_B=F6hmwalder?= In-Reply-To: <1f1a7b29-b767-551c-e2ec-d5cdf5ceecd0@linbit.com> Message-ID: References: <1f1a7b29-b767-551c-e2ec-d5cdf5ceecd0@linbit.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-179480623-1585325736=:2709" X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Fri, 27 Mar 2020 17:15:40 +0100 (CET) X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Fri, 27 Mar 2020 17:15:36 +0100 (CET) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Cc: Coccinelle Subject: Re: [Cocci] Matching against a declarer macro X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-179480623-1585325736=:2709 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT On Fri, 27 Mar 2020, Christoph Böhmwalder wrote: > Am 27.03.20 um 16:47 schrieb Julia Lawall:> Are you sure that the C code is > parsed successfully? I'm not at all sure > > that static is allowed in an argument list. Types are allowed, bu static > > is only part of a type. > > I'm pretty sure it is parsed successfully. At least spatch doesn't complain > about it, no matter how many debug flags I specify. Did you try spatch --parse-c file.c? > > I really only want to swap out the last parameter, but I'm having trouble > coming up with the syntax. This should match, right? > > @@ > declarer name RB_DECLARE_CALLBACKS_MAX; > identifier NODE_END; > @@ > RB_DECLARE_CALLBACKS_MAX(..., > - NODE_END > + compute_subtree_last > ); If the code is getting parsed, this should be fine. Do you want to actually match NODE_END? If so, it shouldn't be declared as a metavariable. julia > > For augment_callbacks, either identifier or expression would be fine. > > Coccinelle has no idea what is going to happen to augment_callbacks > > afterwards. It just sees a sequence of characters and classifies it as an > > identifier. > > That's what I thought, thank you for confirming. > > > julia > --8323329-179480623-1585325736=:2709 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci --8323329-179480623-1585325736=:2709--