From: Julia Lawall <julia.lawall@inria.fr>
To: Paul Chaignon <paul@cilium.io>
Cc: cocci@systeme.lip6.fr, paul.chaignon@gmail.com
Subject: Re: [Cocci] Using a macro for variable attributes
Date: Tue, 28 Apr 2020 19:44:15 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2004281943320.3273@hadrien> (raw)
In-Reply-To: <20200428101124.GA18321@Mem>
On Tue, 28 Apr 2020, Paul Chaignon wrote:
> Hi all,
>
> I am working on a small semantic patch to annotate specific variables in
> our codebase with __attribute__((aligned(8))). The following program works
> fine.
>
> @r@
> expression e1, e2;
> identifier x;
> @@
> (
> struct \(icmphdr\|icmp6hdr\) x
> + __attribute__((aligned(8)))
> ;
> |
> struct \(icmphdr\|icmp6hdr\) x
> + __attribute__((aligned(8)))
> = ...;
> )
> ... when exists
> ctx_load_bytes(e1, e2, &x, ...)
>
> However, when I replace __attribute__((aligned(8))) with our internal
> macro __align_stack_8, it fails with the following error:
>
> plus: parse error:
> File "/home/paul/cilium/contrib/coccinelle/aligned.cocci", line 7, column 2, charpos = 77
> around = '__align_stack_8',
> whole content = + __align_stack_8
>
> I've tried adding '#define __align_stack_8' in a file passed with
> --macro-file, without success. Is this a known limitation for macros or
> am I missing something?
Try adding the "metavariable" declaration:
attribute name __align_stack_8;
julia
>
> Thanks,
> Paul
> _______________________________________________
> Cocci mailing list
> Cocci@systeme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci
>
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2020-04-28 17:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 10:11 [Cocci] Using a macro for variable attributes Paul Chaignon
2020-04-28 17:44 ` Julia Lawall [this message]
2020-04-28 18:17 ` Paul Chaignon
2020-04-28 18:41 ` Julia Lawall
2020-04-28 18:58 ` Paul Chaignon
2020-04-30 15:40 ` Jaskaran Singh
2020-05-01 13:45 ` Paul Chaignon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2004281943320.3273@hadrien \
--to=julia.lawall@inria.fr \
--cc=cocci@systeme.lip6.fr \
--cc=paul.chaignon@gmail.com \
--cc=paul@cilium.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).