From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 816C0C28CBC for ; Sun, 3 May 2020 19:28:36 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2263D2054F for ; Sun, 3 May 2020 19:28:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2263D2054F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=inria.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id 043JSOjI009638; Sun, 3 May 2020 21:28:24 +0200 (CEST) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id 94E0B7763; Sun, 3 May 2020 21:28:24 +0200 (CEST) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id 071B93C89 for ; Sun, 3 May 2020 21:28:23 +0200 (CEST) Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTPS id 043JSMP2023208 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 3 May 2020 21:28:22 +0200 (CEST) X-IronPort-AV: E=Sophos;i="5.73,349,1583190000"; d="scan'208";a="347593895" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 May 2020 21:28:22 +0200 Date: Sun, 3 May 2020 21:28:21 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Jaskaran Singh In-Reply-To: <20200428170228.7002-10-jaskaransingh7654321@gmail.com> Message-ID: References: <20200428170228.7002-1-jaskaransingh7654321@gmail.com> <20200428170228.7002-10-jaskaransingh7654321@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Sun, 03 May 2020 21:28:24 +0200 (CEST) X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Sun, 03 May 2020 21:28:22 +0200 (CEST) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Cc: linux-kernel-mentees@lists.linuxfoundation.org, cocci@systeme.lip6.fr Subject: Re: [Cocci] [PATCH 09/32] parsing_cocci: arity: Reflect Cast attributes X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr On Tue, 28 Apr 2020, Jaskaran Singh wrote: > Cast attributes are added to the SmPL AST. Reflect these changes in > arity.ml. > > Signed-off-by: Jaskaran Singh > --- > parsing_cocci/arity.ml | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/parsing_cocci/arity.ml b/parsing_cocci/arity.ml > index 8ee6d33f..880cd7a3 100644 > --- a/parsing_cocci/arity.ml > +++ b/parsing_cocci/arity.ml > @@ -254,13 +254,14 @@ let rec top_expression opt_allowed tgt expr = > let ar = mcode ar in > let field = ident false arity field in > make_exp expr tgt arity (Ast0.RecordPtAccess(exp,ar,field)) > - | Ast0.Cast(lp,ty,rp,exp) -> > + | Ast0.Cast(lp,ty,attr,rp,exp) -> > let arity = exp_same (mcode2line lp) [mcode2arity lp;mcode2arity rp] in > let lp = mcode lp in > let ty = typeC arity ty in > + let attr = List.map mcode attr in Since attrs are mcodes, they should be reflected in the list that is given to exp_same. julia > let rp = mcode rp in > let exp = expression arity exp in > - make_exp expr tgt arity (Ast0.Cast(lp,ty,rp,exp)) > + make_exp expr tgt arity (Ast0.Cast(lp,ty,attr,rp,exp)) > | Ast0.SizeOfExpr(szf,exp) -> > let arity = exp_same (mcode2line szf) [mcode2arity szf] in > let szf = mcode szf in > -- > 2.21.1 > > _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci