From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44663C28CBC for ; Sun, 3 May 2020 19:32:48 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8AC12068E for ; Sun, 3 May 2020 19:32:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8AC12068E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=inria.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id 043JWdKj000798; Sun, 3 May 2020 21:32:39 +0200 (CEST) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id 1045D7763; Sun, 3 May 2020 21:32:39 +0200 (CEST) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id 2F7C13C89 for ; Sun, 3 May 2020 21:32:38 +0200 (CEST) Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTPS id 043JWaTU004047 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 3 May 2020 21:32:37 +0200 (CEST) X-IronPort-AV: E=Sophos;i="5.73,349,1583190000"; d="scan'208";a="347594006" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 May 2020 21:32:36 +0200 Date: Sun, 3 May 2020 21:32:36 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Jaskaran Singh In-Reply-To: <20200428170228.7002-23-jaskaransingh7654321@gmail.com> Message-ID: References: <20200428170228.7002-1-jaskaransingh7654321@gmail.com> <20200428170228.7002-23-jaskaransingh7654321@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Sun, 03 May 2020 21:32:39 +0200 (CEST) X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Sun, 03 May 2020 21:32:37 +0200 (CEST) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Cc: linux-kernel-mentees@lists.linuxfoundation.org, cocci@systeme.lip6.fr Subject: Re: [Cocci] [PATCH 22/32] parsing_c: pretty_print_c: Reflect Cast attributes X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr On Tue, 28 Apr 2020, Jaskaran Singh wrote: > Cast attributes are added to the SmPL AST. Print these attributes in > pretty_print_c.ml. > > Signed-off-by: Jaskaran Singh > --- > parsing_c/pretty_print_c.ml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/parsing_c/pretty_print_c.ml b/parsing_c/pretty_print_c.ml > index 99a7e0ed..96a11d72 100644 > --- a/parsing_c/pretty_print_c.ml > +++ b/parsing_c/pretty_print_c.ml > @@ -146,8 +146,9 @@ let mk_pretty_printers > pp_expression e > | SizeOfType (t), [i1;i2;i3] -> > pr_elem i1; pr_elem i2; pp_type t; pr_elem i3 > - | Cast (t, e), [i1;i2] -> > - pr_elem i1; pp_type t; pr_elem i2; pp_expression e > + | Cast (t, e, a), [i1;i2] -> Less space in front of the [ julia > + pr_elem i1; pp_type t; pr_elem i2; pp_expression e; > + a +> pp_attributes pr_elem pr_space > > | StatementExpr (statxs, [ii1;ii2]), [i1;i2] -> > pr_elem i1; > @@ -184,7 +185,7 @@ let mk_pretty_printers > | CondExpr (_,_,_) | Sequence (_,_) | Assignment (_,_,_) > | Postfix (_,_) | Infix (_,_) | Unary (_,_) | Binary (_,_,_) > | ArrayAccess (_,_) | RecordAccess (_,_) | RecordPtAccess (_,_) > - | SizeOfExpr (_) | SizeOfType (_) | Cast (_,_) > + | SizeOfExpr (_) | SizeOfType (_) | Cast (_,_,_) > | StatementExpr (_) | Constructor _ > | ParenExpr (_) | New (_) | Delete (_,_) > | Defined (_)),_ -> raise (Impossible 95) > -- > 2.21.1 > > _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci