From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E39D0C433E0 for ; Sun, 21 Jun 2020 20:54:01 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 285432528B for ; Sun, 21 Jun 2020 20:54:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 285432528B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=inria.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id 05LKrSVh010067; Sun, 21 Jun 2020 22:53:28 +0200 (CEST) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id 394E67773; Sun, 21 Jun 2020 22:53:28 +0200 (CEST) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id 0D69A3D0F for ; Sun, 21 Jun 2020 22:53:26 +0200 (CEST) Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTPS id 05LKrPIM021435 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 21 Jun 2020 22:53:25 +0200 (CEST) X-IronPort-AV: E=Sophos;i="5.75,264,1589234400"; d="scan'208";a="455861131" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jun 2020 22:53:24 +0200 Date: Sun, 21 Jun 2020 22:53:24 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Denis Efremov In-Reply-To: <20200619131313.15468-1-efremov@linux.com> Message-ID: References: <20200615102045.4558-1-efremov@linux.com> <20200619131313.15468-1-efremov@linux.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Sun, 21 Jun 2020 22:53:28 +0200 (CEST) X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Sun, 21 Jun 2020 22:53:25 +0200 (CEST) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Cc: linux-kernel@vger.kernel.org, Kees Cook , cocci@systeme.lip6.fr Subject: Re: [Cocci] [PATCH v3] coccinelle: misc: add array_size_dup script to detect missed overflow checks X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr > +@as_next@ > +expression subE1 <= as.E1; > +expression subE2 <= as.E2; > +expression as.E1, as.E2, E3; > +assignment operator aop; > +position p1, p2; > +@@ > + > +* E1 * E2@p1 > + ... when != \(E1\|E2\|subE1\|subE2\) aop E3 > + when != &\(E1\|E2\|subE1\|subE2\) You don't need E1 and E2 in the above two lines. subE1 and subE2 will match them. Likewise for the other rules. > +* array_size(E1, E2)@p2 > + > +@script:python depends on report@ > +p1 << as_next.p1; > +p2 << as_next.p2; > +@@ > + > +coccilib.report.print_report(p1[0], > +f"WARNING: array_size is used down the code (line {p2[0].line}) to compute the same size") I don't think that "down the code" is very understandable. "Later in the code" would be fine. Even just "later" would be fine. julia > +@script:python depends on org@ > +p1 << as_next.p1; > +p2 << as_next.p2; > +@@ > + > +coccilib.org.print_todo(p1[0], > +f"WARNING: array_size is used down the code (line {p2[0].line}) to compute the same size") > + > +@as_prev@ > +expression subE1 <= as.E1; > +expression subE2 <= as.E2; > +expression as.E1, as.E2, E3; > +assignment operator aop; > +position p1, p2; > +@@ > + > +* array_size(E1, E2)@p1 > + ... when != \(E1\|E2\|subE1\|subE2\) aop E3 > + when != &\(E1\|E2\|subE1\|subE2\) > +* E1 * E2@p2 > + > +@script:python depends on report@ > +p1 << as_prev.p1; > +p2 << as_prev.p2; > +@@ > + > +coccilib.report.print_report(p2[0], > +f"WARNING: array_size is already used (line {p1[0].line}) to compute the same size") > + > +@script:python depends on org@ > +p1 << as_prev.p1; > +p2 << as_prev.p2; > +@@ > + > +coccilib.org.print_todo(p2[0], > +f"WARNING: array_size is already used (line {p1[0].line}) to compute the same size") > + > +@as_dup@ > +expression subE1 <= as.E1; > +expression subE2 <= as.E2; > +expression as.E1, as.E2, E3; > +assignment operator aop; > +position p1, p2; > +@@ > + > +* array_size(E1, E2)@p1 > + ... when != \(E1\|E2\|subE1\|subE2\) aop E3 > + when != &\(E1\|E2\|subE1\|subE2\) > +* array_size(E1, E2)@p2 > + > +@script:python depends on report@ > +p1 << as_dup.p1; > +p2 << as_dup.p2; > +@@ > + > +coccilib.report.print_report(p2[0], > +f"WARNING: same array_size (line {p1[0].line})") > + > +@script:python depends on org@ > +p1 << as_dup.p1; > +p2 << as_dup.p2; > +@@ > + > +coccilib.org.print_todo(p2[0], > +f"WARNING: same array_size (line {p1[0].line})") > + > +@as3@ > +expression E1, E2, E3; > +@@ > + > +array3_size(E1, E2, E3) > + > +@as3_next@ > +expression subE1 <= as3.E1; > +expression subE2 <= as3.E2; > +expression subE3 <= as3.E3; > +expression as3.E1, as3.E2, as3.E3, E4; > +assignment operator aop; > +position p1, p2; > +@@ > + > +* E1 * E2 * E3@p1 > + ... when != \(E1\|E2\|E3\|subE1\|subE2\|subE3\) aop E4 > + when != &\(E1\|E2\|E3\|subE1\|subE2\|subE3\) > +* array3_size(E1, E2, E3)@p2 > + > +@script:python depends on report@ > +p1 << as3_next.p1; > +p2 << as3_next.p2; > +@@ > + > +coccilib.report.print_report(p1[0], > +f"WARNING: array3_size is used down the code (line {p2[0].line}) to compute the same size") > + > +@script:python depends on org@ > +p1 << as3_next.p1; > +p2 << as3_next.p2; > +@@ > + > +coccilib.org.print_todo(p1[0], > +f"WARNING: array3_size is used down the code (line {p2[0].line}) to compute the same size") > + > +@as3_prev@ > +expression subE1 <= as3.E1; > +expression subE2 <= as3.E2; > +expression subE3 <= as3.E3; > +expression as3.E1, as3.E2, as3.E3, E4; > +assignment operator aop; > +position p1, p2; > +@@ > + > +* array3_size(E1, E2, E3)@p1 > + ... when != \(E1\|E2\|E3\|subE1\|subE2\|subE3\) aop E4 > + when != &\(E1\|E2\|E3\|subE1\|subE2\|subE3\) > +* E1 * E2 * E3@p2 > + > +@script:python depends on report@ > +p1 << as3_prev.p1; > +p2 << as3_prev.p2; > +@@ > + > +coccilib.report.print_report(p2[0], > +f"WARNING: array3_size is already used (line {p1[0].line}) to compute the same size") > + > +@script:python depends on org@ > +p1 << as3_prev.p1; > +p2 << as3_prev.p2; > +@@ > + > +coccilib.org.print_todo(p2[0], > +f"WARNING: array3_size is already used (line {p1[0].line}) to compute the same size") > + > +@as3_dup@ > +expression subE1 <= as3.E1; > +expression subE2 <= as3.E2; > +expression subE3 <= as3.E3; > +expression as3.E1, as3.E2, as3.E3, E4; > +assignment operator aop; > +position p1, p2; > +@@ > + > +* array3_size(E1, E2, E3)@p1 > + ... when != \(E1\|E2\|E3\|subE1\|subE2\|subE3\) aop E4 > + when != &\(E1\|E2\|E3\|subE1\|subE2\|subE3\) > +* array3_size(E1, E2, E3)@p2 > + > +@script:python depends on report@ > +p1 << as3_dup.p1; > +p2 << as3_dup.p2; > +@@ > + > +coccilib.report.print_report(p2[0], > +f"WARNING: same array3_size (line {p1[0].line})") > + > +@script:python depends on org@ > +p1 << as3_dup.p1; > +p2 << as3_dup.p2; > +@@ > + > +coccilib.org.print_todo(p2[0], > +f"WARNING: same array3_size (line {p1[0].line})") > + > +@ss@ > +expression E1, E2, E3; > +@@ > + > +struct_size(E1, E2, E3) > + > +@ss_next@ > +expression subE3 <= ss.E3; > +expression ss.E1, ss.E2, ss.E3, E4; > +assignment operator aop; > +position p1, p2; > +@@ > + > +* E1 * E2 + E3@p1 > + ... when != \(E3\|subE3\) aop E4 > + when != &\(E3\|subE3\) > +* struct_size(E1, E2, E3)@p2 > + > +@script:python depends on report@ > +p1 << ss_next.p1; > +p2 << ss_next.p2; > +@@ > + > +coccilib.report.print_report(p1[0], > +f"WARNING: struct_size is used down the code (line {p2[0].line}) to compute the same size") > + > +@script:python depends on org@ > +p1 << ss_next.p1; > +p2 << ss_next.p2; > +@@ > + > +coccilib.org.print_todo(p1[0], > +f"WARNING: struct_size is used down the code (line {p2[0].line}) to compute the same size") > + > +@ss_prev@ > +expression subE3 <= ss.E3; > +expression ss.E1, ss.E2, ss.E3, E4; > +assignment operator aop; > +position p1, p2; > +@@ > + > +* struct_size(E1, E2, E3)@p1 > + ... when != \(E3\|subE3\) aop E4 > + when != &\(E3\|subE3\) > +* E1 * E2 + E3@p2 > + > +@script:python depends on report@ > +p1 << ss_prev.p1; > +p2 << ss_prev.p2; > +@@ > + > +coccilib.report.print_report(p2[0], > +f"WARNING: struct_size is already used (line {p1[0].line}) to compute the same size") > + > +@script:python depends on org@ > +p1 << ss_prev.p1; > +p2 << ss_prev.p2; > +@@ > + > +coccilib.org.print_todo(p2[0], > +f"WARNING: struct_size is already used (line {p1[0].line}) to compute the same size") > + > +@ss_dup@ > +expression subE3 <= ss.E3; > +expression ss.E1, ss.E2, ss.E3, E4; > +assignment operator aop; > +position p1, p2; > +@@ > + > +* struct_size(E1, E2, E3)@p1 > + ... when != \(E3\|subE3\) aop E4 > + when != &\(E3\|subE3\) > +* struct_size(E1, E2, E3)@p2 > + > +@script:python depends on report@ > +p1 << ss_dup.p1; > +p2 << ss_dup.p2; > +@@ > + > +coccilib.report.print_report(p2[0], > +f"WARNING: same struct_size (line {p1[0].line})") > + > +@script:python depends on org@ > +p1 << ss_dup.p1; > +p2 << ss_dup.p2; > +@@ > + > +coccilib.org.print_todo(p2[0], > +f"WARNING: same struct_size (line {p1[0].line})") > -- > 2.26.2 > > _______________________________________________ > Cocci mailing list > Cocci@systeme.lip6.fr > https://systeme.lip6.fr/mailman/listinfo/cocci > _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci