Coccinelle archive on lore.kernel.org
 help / color / Atom feed
From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] Checking the display of SmPL isomorphism results (with pointers)
Date: Fri, 26 Jun 2020 09:44:45 +0200 (CEST)
Message-ID: <alpine.DEB.2.22.394.2006260943310.2455@hadrien> (raw)
In-Reply-To: <fbcead0d-c798-63b7-2d08-e3ee1c7c38a1@web.de>


[-- Attachment #1: Type: text/plain, Size: 930 bytes --]



On Fri, 26 Jun 2020, Markus Elfring wrote:

> Hello,
>
> I have tried another tiny script variant out for the semantic patch language
> (according to the software combination “Coccinelle 1.0.8-00131-g675b9670”).
>
> @display@
> expression* x;
> statement is, es;
> @@
> *if (!x)
>     is
>  else
>     es
>
>
> elfring@Sonne:~/Projekte/Coccinelle/janitor> spatch --parse-cocci show_null_pointer_checks.cocci
> …
> if (*!*x *!= *NULL)
> …
> if (*!*NULL *!= *x)
> …
> if (*x *!= *NULL *== *NULL)
> …
> if (*NULL *!= *x *== *NULL)
> …
> if (*NULL *== *x *!= *NULL)
> …
> if (*NULL *== *NULL *!= *x)
> …
>
>
> Now I find the shown lines in such a program output questionable.
> Should these presentations of elements in SmPL disjunctions be shorter?

It could probably be improved, but it is difficult to do something
perfect.  Still, I'm confused about the double comparison to NULL, so I
will check on it.

julia

[-- Attachment #2: Type: text/plain, Size: 136 bytes --]

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-26  6:36 Markus Elfring
2020-06-26  7:44 ` Julia Lawall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.22.394.2006260943310.2455@hadrien \
    --to=julia.lawall@inria.fr \
    --cc=Markus.Elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Coccinelle archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/cocci/0 cocci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 cocci cocci/ https://lore.kernel.org/cocci \
		cocci@systeme.lip6.fr
	public-inbox-index cocci

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/fr.lip6.systeme.cocci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git