Coccinelle archive on lore.kernel.org
 help / color / Atom feed
From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: cocci@systeme.lip6.fr
Subject: Re: [Cocci] [00/43] cocci: Add support for meta attributes to SmPL
Date: Sun, 2 Aug 2020 19:00:57 +0200 (CEST)
Message-ID: <alpine.DEB.2.22.394.2008021859010.2531@hadrien> (raw)
In-Reply-To: <74a5a472-4431-46e7-bd8b-95886f031c93@web.de>


[-- Attachment #1: Type: text/plain, Size: 2001 bytes --]



On Sun, 2 Aug 2020, Markus Elfring wrote:

> >> How do you distinguish between metavariables and other SmPL variables then?
> >
> > Metavariables don't have "name" in their declaration.  There is a sentence
> > about that in the documentation.
> >
> > The {\bf name} modifier specifies that instead of declaring a metavariable
> > to match over some kind, the identifiers are to be considered as elements
> > of that kind when they appear in the code.
>
> See also:
> https://github.com/coccinelle/coccinelle/blob/e06b9156dfa02a28cf3cbf0913a10513f3d163ab/docs/manual/cocci_syntax.tex#L458
>
>
> > "instead of declaring a metavariable" says that the thing that is declared
> > is not a metavariable.
>
> It seems that we stumble on different interpretations also around a wording
> like “to match over some kind”.
>
> * Which is the category of SmPL identifiers which contain the key word “name”
>   in their data type (or “kind” if you would like to prevent to denote them
>   as metavariables)?

The ones that have "name" in the BNF.

>
> * How do you think about to add square brackets to a line in the TeX SmPL grammar?
>   https://github.com/coccinelle/coccinelle/blob/e06b9156dfa02a28cf3cbf0913a10513f3d163ab/docs/manual/cocci_syntax.tex#L245
>
>   \CASE{attribute \opt{name} \NT{ids} ;}

No, there will be a separate entry for attribute name;.  Putting \opt{}
would lead to the confusion that you are falling into.  They are different
things.

>
> >> Should software users get informed about unused items in consistent ways?
> >> https://github.com/coccinelle/coccinelle/blob/04f36d537b9f6c0c127d05184cccd21f1a46b952/parsing_cocci/check_meta.ml#L711
>
> Do you care if a SmPL name variable would accidentally not be used
> (like in the script “https://github.com/coccinelle/coccinelle/blob/04f36d537b9f6c0c127d05184cccd21f1a46b952/tests/metaattr.cocci#L2”)?

It actually is used, to help parsing the .c file.  This information will
be added to the documentation shortly.

julia

[-- Attachment #2: Type: text/plain, Size: 136 bytes --]

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  parent reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <e4f3c4e8-03e8-dbc2-5871-0d111b3086a4@web.de>
2020-08-02  7:06 ` [Cocci] [PATCH 00/43] " Julia Lawall
     [not found]   ` <eead5e2a-da8d-83cd-eeb4-f193702b800f@web.de>
2020-08-02 11:48     ` Julia Lawall
     [not found]       ` <82af6b44-ea09-b86f-81f7-e96e8594a31d@web.de>
2020-08-02 13:13         ` [Cocci] [00/43] " Julia Lawall
     [not found]           ` <065fee88-5206-5d9b-c83c-4e6a20aefd85@web.de>
2020-08-02 14:34             ` Julia Lawall
     [not found]               ` <8f357aa0-7811-a5b8-a061-814899654e88@web.de>
2020-08-02 15:34                 ` Julia Lawall
     [not found]                   ` <c1822815-456f-316d-93b5-88beb55a0d69@web.de>
2020-08-02 16:16                     ` Julia Lawall
     [not found]                       ` <74a5a472-4431-46e7-bd8b-95886f031c93@web.de>
2020-08-02 17:00                         ` Julia Lawall [this message]
     [not found]                           ` <3474ebf5-c902-63e9-8244-08a0f3407b72@web.de>
2020-08-03  5:46                             ` Julia Lawall
2020-08-03  8:22                             ` Jaskaran Singh
     [not found]                               ` <04cb5eb3-bed8-9e8e-255b-fbae06144016@web.de>
2020-08-08 11:35                                 ` Jaskaran Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.22.394.2008021859010.2531@hadrien \
    --to=julia.lawall@inria.fr \
    --cc=Markus.Elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Coccinelle archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/cocci/0 cocci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 cocci cocci/ https://lore.kernel.org/cocci \
		cocci@systeme.lip6.fr
	public-inbox-index cocci

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/fr.lip6.systeme.cocci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git